Skip to content

Commit eefffb5

Browse files
committed
bugzilla3: Remove hacky getbugfields impl
bugfields used to be called unconditionally in the Bugzilla class, so finding a way to implement this was important. That's not the case nowadays, so drop the untested hacky impl.
1 parent 3b8d979 commit eefffb5

1 file changed

Lines changed: 0 additions & 32 deletions

File tree

bugzilla/bugzilla3.py

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -13,48 +13,16 @@
1313

1414

1515
class Bugzilla3(BugzillaBase):
16-
'''Concrete implementation of the Bugzilla protocol. This one uses the
17-
methods provided by standard Bugzilla 3.0.x releases.'''
1816
version = '0.1'
1917
bz_ver_major = 3
2018
bz_ver_minor = 0
2119

2220

23-
# Connect the backend methods to the XMLRPC methods
24-
def _getbugfields(self):
25-
'''Get a list of valid fields for bugs.'''
26-
# BZ3 doesn't currently provide anything like the getbugfields()
27-
# method, so we fake it by looking at bug #1. Yuck.
28-
# And at least gnome.bugzilla.org fails to lookup bug #1, so
29-
# try a few
30-
err = False
31-
for bugid in [1, 100000]:
32-
try:
33-
keylist = self._getbug(bugid).keys()
34-
err = False
35-
break
36-
except Exception:
37-
err = True
38-
39-
if err:
40-
raise
41-
42-
return keylist
43-
44-
45-
# Bugzilla 3.2 adds some new goodies on top of Bugzilla3.
4621
class Bugzilla32(Bugzilla3):
47-
'''Concrete implementation of the Bugzilla protocol. This one uses the
48-
methods provided by standard Bugzilla 3.2.x releases.
49-
50-
For further information on the methods defined here, see the API docs:
51-
http://www.bugzilla.org/docs/3.2/en/html/api/
52-
'''
5322
version = '0.1'
5423
bz_ver_minor = 2
5524

5625

57-
# Bugzilla 3.4 adds some new goodies on top of Bugzilla32.
5826
class Bugzilla34(Bugzilla32):
5927
version = '0.2'
6028
bz_ver_minor = 4

0 commit comments

Comments
 (0)