cli: add the option to skip obsolete attachments with --get-all

ckalina · crobinso · commit b5d78155d169 · 2019-11-18T11:42:56.000-05:00
Introduce --ignore-obsolete. When used (e.g., with attach --get-all),
obsolete attachments are ignored and not downloaded.

Signed-off-by: &#268;estm&iacute;r Kalina &lt;ckalina@redhat.com&gt;
diff --git a/bugzilla/_cli.py b/bugzilla/_cli.py
@@ -403,7 +403,7 @@ def _setup_action_modify_parser(subparsers):
 def _setup_action_attach_parser(subparsers):
     usage = """
 bugzilla attach --file=FILE --desc=DESC [--type=TYPE] BUGID [BUGID...]
-bugzilla attach --get=ATTACHID --getall=BUGID [...]
+bugzilla attach --get=ATTACHID --getall=BUGID [--ignore-obsolete] [...]
 bugzilla attach --type=TYPE BUGID [BUGID...]"""
     description = "Attach files or download attachments."
     p = subparsers.add_parser("attach", description=description, usage=usage)
@@ -420,6 +420,8 @@ def _setup_action_attach_parser(subparsers):
             default=[], help="Download the attachment with the given ID")
     p.add_argument("--getall", "--get-all", metavar="BUGID", action="append",
             default=[], help="Download all attachments on the given bug")
+    p.add_argument('--ignore-obsolete', action="store_true",
+        help='Do not download attachments marked as obsolete.')
     p.add_argument('-l', '--comment', '--long_desc',
             help="Add comment with attachment")
     p.add_argument('--private', action='store_true', default=False,
@@ -977,6 +979,11 @@ def _do_get_attach(bz, opt):
         opt.get += bug.get_attachment_ids()
 
     for attid in set(opt.get):
+        if opt.ignore_obsolete:
+            metadata = bz.get_attachments(None, attid,
+                                          include_fields=["is_obsolete"])
+            if metadata["attachments"][str(attid)]['is_obsolete'] == 1:
+                continue
         att = bz.openattachment(attid)
         outfile = open_without_clobber(att.name, "wb")
         data = att.read(4096)
