bugzilla: Use bug.update_attachment API

crobinso · crobinso · commit b54420db17b0 · 2016-12-15T16:18:17.000-05:00
Not RHBZ's old custom Flag.update. Public RHBZ supports
update_attachment, which is supported by bugzilla 5+
diff --git a/bugzilla/base.py b/bugzilla/base.py
@@ -1510,16 +1510,16 @@ def updateattachmentflags(self, bugid, attachid, flagname, **kwargs):
             status:    new status for the flag ('-', '+', '?', 'X')
             requestee: new requestee for the flag
         '''
-        update = {
-            'name': flagname,
-            'attach_id': int(attachid),
-        }
-        update.update(kwargs.items())
+        # Bug ID was used for the original custom redhat API, no longer
+        # needed though
+        ignore = bugid
+
+        flags = {"name": flagname}
+        flags.update(kwargs)
+        update = {'ids': [int(attachid)], 'flags': [flags]}
 
-        result = self._proxy.Flag.update({
-            'ids': [int(bugid)],
-            'updates': [update]})
-        return result['flag_updates'][str(bugid)]
+        log.debug("Calling Bug.update_attachment(%s)", update)
+        return self._proxy.Bug.update_attachment(update)
 
 
     #####################
