tests: Add unit test case for bug attr handling

crobinso · crobinso · commit a303fa0e0fa6 · 2014-04-14T12:12:41.000-04:00
diff --git a/bugzilla/bug.py b/bugzilla/bug.py
@@ -66,7 +66,9 @@ def __repr__(self):
     def __getattr__(self, name):
         refreshed = False
         while True:
-            if name in self.__dict__:
+            if refreshed and name in self.__dict__:
+                # If name was in __dict__ to begin with, __getattr__ would
+                # have never been called.
                 return self.__dict__[name]
 
             # Check field aliases
@@ -94,15 +96,6 @@ def __getattr__(self, name):
 
         raise AttributeError("Bug object has no attribute '%s'" % name)
 
-    def __hasattr__(self, name):
-        if name in self.__dict__:
-            return True
-
-        for newname, oldname in self.bugzilla.field_aliases:
-            if name == oldname and newname in self.__dict__:
-                return True
-        return False
-
     def __getstate__(self):
         sd = self.__dict__
         if self.bugzilla:
diff --git a/tests/bug.py b/tests/bug.py
@@ -0,0 +1,51 @@
+#
+# Copyright Red Hat, Inc. 2014
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or later.
+# See the COPYING file in the top-level directory.
+#
+
+'''
+Unit tests for testing some bug.py magic
+'''
+
+import unittest
+
+from bugzilla import RHBugzilla
+from bugzilla.bug import _Bug
+
+import tests
+
+
+rhbz = RHBugzilla(cookiefile=None)
+
+
+class BugTest(unittest.TestCase):
+    maxDiff = None
+    bz = rhbz
+
+    def testBasic(self):
+        data = {
+            "bug_id": 123456,
+            "component": "foo",
+            "product": "bar",
+            "short_desc": "some short desc",
+            "cf_fixed_in": "nope",
+            "fixed_in": "1.2.3.4",
+            "devel_whiteboard": "some status value",
+        }
+
+        bug = _Bug(bugzilla=self.bz, dict=data)
+
+        self.assertEqual(hasattr(bug, "component"), True)
+        self.assertEqual(getattr(bug, "components"), ["foo"])
+        self.assertEqual(getattr(bug, "product"), "bar")
+        self.assertEqual(hasattr(bug, "short_desc"), True)
+        self.assertEqual(getattr(bug, "summary"), "some short desc")
+        self.assertEqual(bool(getattr(bug, "cf_fixed_in")), True)
+        self.assertEqual(getattr(bug, "fixed_in"), "1.2.3.4")
+        self.assertEqual(bool(getattr(bug, "cf_devel_whiteboard")), True)
+        self.assertEqual(getattr(bug, "devel_whiteboard"), "some status value")
+
+        # This triggers some code in __getattr__
+        dir(bug)
