setup: Rework 'rpm' command slightly

crobinso · crobinso · commit 9c2880e164b8 · 2020-07-04T13:06:33.000-04:00
- Use subprocess
- Return error on failure
- Force output in the source directory
- Drop the /tmp spec handling which was an artifact of my local config

Signed-off-by: Cole Robinson &lt;crobinso@redhat.com&gt;
diff --git a/setup.py b/setup.py
@@ -64,7 +64,8 @@ def run(self):
 
 
 class RPMCommand(Command):
-    description = "Build src and binary rpms."
+    description = ("Build src and binary rpms and output them "
+        "in the source directory")
     user_options = []
 
     def initialize_options(self):
@@ -73,17 +74,15 @@ def finalize_options(self):
         pass
 
     def run(self):
-        """
-        Run sdist, then 'rpmbuild' the tar.gz
-        """
-        os.system("cp python-bugzilla.spec /tmp")
-        try:
-            os.system("rm -rf python-bugzilla-%s" % get_version())
-            self.run_command('sdist')
-            os.system('rpmbuild -ta --clean dist/python-bugzilla-%s.tar.gz' %
-                      get_version())
-        finally:
-            os.system("mv /tmp/python-bugzilla.spec .")
+        self.run_command('sdist')
+        srcdir = os.path.dirname(__file__)
+        cmd = [
+            "rpmbuild", "-ta",
+            "--define", "_rpmdir %s" % srcdir,
+            "--define", "_srcrpmdir %s" % srcdir,
+            "dist/python-bugzilla-%s.tar.gz" % get_version(),
+        ]
+        subprocess.check_call(cmd)
 
 
 class BuildCommand(distutils.command.build.build):
