setup: Make man page generation optional

crobinso · crobinso · commit 80c451e2f846 · 2020-01-14T10:13:37.000-05:00
rst2man doesn't appear to be in /usr/bin via pip packages, so
make manpage building optional

Signed-off-by: Cole Robinson &lt;crobinso@redhat.com&gt;
diff --git a/python-bugzilla.spec b/python-bugzilla.spec
@@ -99,23 +99,10 @@ cp -a . %{py3dir}
 
 
 
-%build
-%if %{with python3}
-pushd %{py3dir}
-%{__python3} setup.py build
-popd
-%endif
-
-%if %{with python2}
-%{__python2} setup.py build
-%endif
-
-
-
 %install
 %if %{with python3}
 pushd %{py3dir}
-%{__python3} setup.py install -O1 --skip-build --root %{buildroot}
+%{__python3} setup.py install -O1 --root %{buildroot}
 
 %if %{with python2}
 rm %{buildroot}/usr/bin/bugzilla
@@ -125,7 +112,7 @@ popd
 %endif
 
 %if %{with python2}
-%{__python2} setup.py install -O1 --skip-build --root %{buildroot}
+%{__python2} setup.py install -O1 --root %{buildroot}
 %endif
 
 # Replace '#!/usr/bin/env python' with '#!/usr/bin/python2'
diff --git a/requirements.txt b/requirements.txt
@@ -1,2 +1 @@
-docutils
 requests
diff --git a/setup.py b/setup.py
@@ -96,7 +96,10 @@ def _make_man_pages(self):
             print("Generating %s" % newpath)
             ret = os.system('rst2man %s > %s' % (path, newpath))
             if ret != 0:
-                raise RuntimeError("Generating '%s' failed." % newpath)
+                print("Generating '%s' failed." % newpath)
+                continue
+            self.distribution.data_files.append(
+                ('share/man/man1', (newpath,)))
 
     def run(self):
         self._make_man_pages()
@@ -135,8 +138,8 @@ def _parse_requirements(fname):
         'Programming Language :: Python :: 3.7',
     ],
     packages=['bugzilla'],
+    data_files=[],
     entry_points={'console_scripts': ['bugzilla = bugzilla._cli:cli']},
-    data_files=[('share/man/man1', ['man/bugzilla.1'])],
 
     install_requires=_parse_requirements("requirements.txt"),
     tests_require=_parse_requirements("test-requirements.txt"),
