Clarify rhbz support for Bug.update alias

crobinso · crobinso · commit 70a1e3162ab1 · 2014-12-11T08:35:54.000-05:00
diff --git a/bugzilla/rhbugzilla.py b/bugzilla/rhbugzilla.py
@@ -104,6 +104,22 @@ def get_sub_component():
                 val = {component[0]: val}
             adddict["sub_components"] = val
 
+        def get_alias():
+            # RHBZ has a custom extension to allow a bug to have multiple
+            # aliases, so the format of aliases is
+            #    {"add": [...], "remove": [...]}
+            # But that means in order to approximate upstream, behavior
+            # which just overwrites the existing alias, we need to read
+            # the bug's state first to know what string to remove. Which
+            # we can't do, since we don't know the bug numbers at this point.
+            # So fail for now.
+            #
+            # The API should provide {"set": [...]}
+            # https://bugzilla.redhat.com/show_bug.cgi?id=1173114
+            if "alias" in kwargs:
+                raise RuntimeError("modify 'alias' not supported for "
+                    "RHBZ")
+
         pop("fixed_in", "cf_fixed_in")
         pop("qa_whiteboard", "cf_qa_whiteboard")
         pop("devel_whiteboard", "cf_devel_whiteboard")
diff --git a/tests/rw_functional.py b/tests/rw_functional.py
@@ -174,8 +174,9 @@ def test4NewBugAllFields(self):
 
         # Close the bug
 
-        # modify alias is busted on the bugzilla side
-        # https://bugzilla.redhat.com/show_bug.cgi?id=1172855
+        # RHBZ makes it difficult to provide consistent semantics for
+        # 'alias' update:
+        # https://bugzilla.redhat.com/show_bug.cgi?id=1173114
         # alias += "-closed"
         tests.clicomm("bugzilla modify "
             "--close WONTFIX %s " %
