test: Use a class to organize tests in test_backend_rest.py

crazyscientist · crobinso · commit 5f89e286041d · 2024-10-11T13:11:52.000-04:00
diff --git a/tests/test_backend_rest.py b/tests/test_backend_rest.py
@@ -4,32 +4,41 @@
 from bugzilla._session import _BugzillaSession
 
 
-def test_getbug():
-    session = _BugzillaSession(url="http://example.com",
+class TestGetBug:
+    @property
+    def session(self):
+        return _BugzillaSession(url="http://example.com",
                                user_agent="py-bugzilla-test",
                                sslverify=False,
                                cert=None,
                                tokencache={},
                                api_key="",
                                is_redhat_bugzilla=False)
-    backend = _BackendREST(url="http://example.com",
-                           bugzillasession=session)
 
-    def _assertion(self, *args):
-        self.assertion_called = True
-        assert args and args[0] == url
+    @property
+    def backend(self):
+        return _BackendREST(url="http://example.com",
+                           bugzillasession=self.session)
 
-    setattr(backend, "_get", MethodType(_assertion, backend))
+    def test_getbug__not_permissive(self):
+        backend = self.backend
 
-    for _ids, aliases, url in (
-            (1, None, "/bug/1"),
-            ([1], [], "/bug/1"),
-            (None, "CVE-1999-0001", "/bug/CVE-1999-0001"),
-            ([], ["CVE-1999-0001"], "/bug/CVE-1999-0001"),
-            (1, "CVE-1999-0001", "/bug"),
-    ):
-        backend.assertion_called = False
+        def _assertion(self, *args):
+            self.assertion_called = True
+            assert args and args[0] == url
 
-        backend.bug_get(_ids, aliases, {})
+        setattr(backend, "_get", MethodType(_assertion, backend))
 
-        assert backend.assertion_called is True
+        for _ids, aliases, url in (
+                (1, None, "/bug/1"),
+                ([1], [], "/bug/1"),
+                (None, "CVE-1999-0001", "/bug/CVE-1999-0001"),
+                ([], ["CVE-1999-0001"], "/bug/CVE-1999-0001"),
+                (1, "CVE-1999-0001", "/bug"),
+                ([1, 2], None, "/bug")
+        ):
+            backend.assertion_called = False
+
+            backend.bug_get(_ids, aliases, {})
+
+            assert backend.assertion_called is True
