Fix uploading binary attachments (bz 1496821)

crobinso · crobinso · commit 49f7d78aaf36 · 2017-10-20T19:38:53.000-04:00
https://bugzilla.redhat.com/show_bug.cgi?id=1496821
diff --git a/bin/bugzilla b/bin/bugzilla
@@ -929,7 +929,7 @@ def _do_set_attach(bz, opt, parser, args):
     if sys.stdin.isatty():
         if not opt.file:
             parser.error("--file must be specified")
-        fileobj = open(opt.file)
+        fileobj = open(opt.file, "rb")
     else:
         # piped input on stdin
         if not opt.desc:
diff --git a/bugzilla/base.py b/bugzilla/base.py
@@ -1481,7 +1481,7 @@ def attachfile(self, idlist, attachfile, description, **kwargs):
         attachment was added, we return the single int ID for back compat
         '''
         if isinstance(attachfile, str):
-            f = open(attachfile)
+            f = open(attachfile, "rb")
         elif hasattr(attachfile, 'read'):
             f = attachfile
         else:
