tests: Add a basic login test

crobinso · crobinso · commit 26570c7ff79d · 2013-01-30T20:11:50.000-05:00
diff --git a/tests/__init__.py b/tests/__init__.py
@@ -27,7 +27,7 @@ def difffile(expect, filename):
 
 
 def clicomm(argv, bzinstance, returnmain=False, printcliout=False,
-            stdin=None):
+            stdin=None, expectfail=False):
     """
     Run bin/bugzilla.main() directly with passed argv
     """
@@ -64,9 +64,13 @@ def clicomm(argv, bzinstance, returnmain=False, printcliout=False,
             if outt.endswith("\n"):
                 outt = outt[:-1]
 
-        if ret != 0:
+        if ret != 0 and not expectfail:
             raise RuntimeError("Command failed with %d\ncmd=%s\nout=%s" %
                                (ret, argv, outt))
+        elif ret == 0 and expectfail:
+            raise RuntimeError("Command succeeded but we expected success\n"
+                               "ret=%d\ncmd=%s\nout=%s" % (ret, argv, outt))
+
         if returnmain:
             return mainout
         return outt
diff --git a/tests/rw_functional.py b/tests/rw_functional.py
@@ -449,3 +449,13 @@ def test9Whiteboards(self):
         self.assertEquals(bug.qa_whiteboard, "")
         self.assertEquals(bug.devel_whiteboard, "")
         self.assertEquals(bug.internal_whiteboard, "")
+
+    def test10Login(self):
+        """
+        Failed login test, gives us a bit more coverage
+        """
+        ret = tests.clicomm("bugzilla --bugzilla %s "
+                            "--user foobar@example.com "
+                            "--password foobar login" % self.url, None,
+                            expectfail=True)
+        self.assertTrue("Logging in... failed." in ret)
