tests: Add ending newline to test data

crobinso · crobinso · commit 225ddb213de0 · 2020-01-10T18:39:54.000-05:00
Makes diffs easier to read

Signed-off-by: Cole Robinson &lt;crobinso@redhat.com&gt;
diff --git a/tests/data/mockargs/test_api_attachments_create1.txt b/tests/data/mockargs/test_api_attachments_create1.txt
@@ -2,4 +2,4 @@
  'file_name': 'bz-attach-get1.txt',
  'ids': [123456],
  'is_private': True,
- 'summary': 'some desc'}
+ 'summary': 'some desc'}
diff --git a/tests/data/mockargs/test_api_component_create1.txt b/tests/data/mockargs/test_api_component_create1.txt
@@ -2,4 +2,4 @@
  'default_cc': 'foo3@example.com',
  'default_qa_contact': 'foo2@example.com',
  'is_active': 0,
- 'product': 'fooproduct'}
+ 'product': 'fooproduct'}
diff --git a/tests/data/mockargs/test_api_component_update1.txt b/tests/data/mockargs/test_api_component_update1.txt
@@ -1,4 +1,4 @@
 {'names': [{'component': 'foocomponent', 'product': 'fooproduct'}],
  'updates': {'blaharg': 'blahval',
              'default_assignee': 'foo@example.com',
-             'is_active': 0}}
+             'is_active': 0}}
diff --git a/tests/data/mockargs/test_api_getbugs1.txt b/tests/data/mockargs/test_api_getbugs1.txt
@@ -1 +1 @@
-{'exclude_fields': 'foo', 'ids': ['CVE-1234-5678']}
+{'exclude_fields': 'foo', 'ids': ['CVE-1234-5678']}
diff --git a/tests/data/mockargs/test_api_login1.txt b/tests/data/mockargs/test_api_login1.txt
@@ -1 +1 @@
-{'login': None, 'password': None}
+{'login': None, 'password': None}
diff --git a/tests/data/mockargs/test_api_products_get1.txt b/tests/data/mockargs/test_api_products_get1.txt
@@ -1 +1 @@
-{'ids': [1, 7]}
+{'ids': [1, 7]}
diff --git a/tests/data/mockargs/test_api_products_get2.txt b/tests/data/mockargs/test_api_products_get2.txt
@@ -1 +1 @@
-{'include_fields': ['name', 'id'], 'names': ['test-fake-product']}
+{'include_fields': ['name', 'id'], 'names': ['test-fake-product']}
diff --git a/tests/data/mockargs/test_api_products_get3.txt b/tests/data/mockargs/test_api_products_get3.txt
@@ -1 +1 @@
-{'include_fields': ['name', 'id', 'components'], 'names': ['test-fake-product']}
+{'include_fields': ['name', 'id', 'components'], 'names': ['test-fake-product']}
diff --git a/tests/data/mockargs/test_api_products_get4.txt b/tests/data/mockargs/test_api_products_get4.txt
@@ -1 +1 @@
-{'exclude_fields': ['product.foo'], 'ids': ['7']}
+{'exclude_fields': ['product.foo'], 'ids': ['7']}
diff --git a/tests/data/mockargs/test_api_products_get5.txt b/tests/data/mockargs/test_api_products_get5.txt
@@ -1 +1 @@
-{'include_fields': ['name', 'id'], 'names': [0]}
+{'include_fields': ['name', 'id'], 'names': [0]}
diff --git a/tests/data/mockargs/test_api_users_create.txt b/tests/data/mockargs/test_api_users_create.txt
@@ -1 +1 @@
-{'email': 'example1@example.com', 'name': 'fooname', 'password': 'foopass'}
+{'email': 'example1@example.com', 'name': 'fooname', 'password': 'foopass'}
diff --git a/tests/data/mockargs/test_api_users_get1.txt b/tests/data/mockargs/test_api_users_get1.txt
@@ -1 +1 @@
-{'names': ['example2@example.com']}
+{'names': ['example2@example.com']}
diff --git a/tests/data/mockargs/test_api_users_get2.txt b/tests/data/mockargs/test_api_users_get2.txt
@@ -1 +1 @@
-{'names': ['example1@example.com']}
+{'names': ['example1@example.com']}
diff --git a/tests/data/mockargs/test_api_users_get3.txt b/tests/data/mockargs/test_api_users_get3.txt
@@ -1 +1 @@
-{'match': ['example1@example.com']}
+{'match': ['example1@example.com']}
diff --git a/tests/data/mockargs/test_api_users_update1.txt b/tests/data/mockargs/test_api_users_update1.txt
@@ -1 +1 @@
-{'groups': {'remove': ['fedora_contrib']}, 'names': ['example name']}
+{'groups': {'remove': ['fedora_contrib']}, 'names': ['example name']}
diff --git a/tests/data/mockargs/test_attach1.txt b/tests/data/mockargs/test_attach1.txt
@@ -4,4 +4,4 @@
  'ids': ['123456'],
  'is_patch': True,
  'is_private': True,
- 'summary': 'bz-attach-get1.txt'}
+ 'summary': 'bz-attach-get1.txt'}
diff --git a/tests/data/mockargs/test_attach2.txt b/tests/data/mockargs/test_attach2.txt
@@ -1,4 +1,4 @@
 {'content_type': 'text/plain',
  'file_name': 'fake-file-name.txt',
  'ids': ['123456'],
- 'summary': 'Some attachment description'}
+ 'summary': 'Some attachment description'}
diff --git a/tests/data/mockargs/test_attach_get1.txt b/tests/data/mockargs/test_attach_get1.txt
@@ -1 +1 @@
-{}
+{}
diff --git a/tests/data/mockargs/test_attach_get2.txt b/tests/data/mockargs/test_attach_get2.txt
@@ -1 +1 @@
-{}
+{}
diff --git a/tests/data/mockargs/test_attachments_get1.txt b/tests/data/mockargs/test_attachments_get1.txt
@@ -1 +1 @@
-{}
+{}
diff --git a/tests/data/mockargs/test_attachments_getall1.txt b/tests/data/mockargs/test_attachments_getall1.txt
@@ -1 +1 @@
-{'exclude_fields': ['bar'], 'include_fields': ['foo']}
+{'exclude_fields': ['bar'], 'include_fields': ['foo']}
diff --git a/tests/data/mockargs/test_attachments_update1.txt b/tests/data/mockargs/test_attachments_update1.txt
@@ -1,2 +1,2 @@
 {'flags': [{'is_patch': True, 'name': 'needinfo', 'value': 'foobar'}],
- 'ids': [112233]}
+ 'ids': [112233]}
diff --git a/tests/data/mockargs/test_bug_api_comments.txt b/tests/data/mockargs/test_bug_api_comments.txt
@@ -1 +1 @@
-{'ids': [1165434]}
+{'ids': [1165434]}
diff --git a/tests/data/mockargs/test_bug_api_get_attachments.txt b/tests/data/mockargs/test_bug_api_get_attachments.txt
@@ -1 +1 @@
-{}
+{}
diff --git a/tests/data/mockargs/test_bug_api_history.txt b/tests/data/mockargs/test_bug_api_history.txt
@@ -1 +1 @@
-{'ids': [1165434]}
+{'ids': [1165434]}
diff --git a/tests/data/mockargs/test_bug_apis_addcc_update.txt b/tests/data/mockargs/test_bug_apis_addcc_update.txt
@@ -1,3 +1,3 @@
 {'cc': {'add': ['foo2@example.com']},
  'comment': {'comment': 'foocomment'},
- 'ids': [1165434]}
+ 'ids': [1165434]}
diff --git a/tests/data/mockargs/test_bug_apis_addcomment_update.txt b/tests/data/mockargs/test_bug_apis_addcomment_update.txt
@@ -1 +1 @@
-{'comment': {'comment': 'test comment', 'is_private': True}, 'ids': [1165434]}
+{'comment': {'comment': 'test comment', 'is_private': True}, 'ids': [1165434]}
diff --git a/tests/data/mockargs/test_bug_apis_close_update.txt b/tests/data/mockargs/test_bug_apis_close_update.txt
@@ -3,4 +3,4 @@
  'dupe_of': 123456,
  'ids': [1165434],
  'resolution': 'UPSTREAM',
- 'status': 'CLOSED'}
+ 'status': 'CLOSED'}
diff --git a/tests/data/mockargs/test_bug_apis_deletecc_update.txt b/tests/data/mockargs/test_bug_apis_deletecc_update.txt
@@ -1,3 +1,3 @@
 {'cc': {'remove': ['foo2@example.com']},
  'comment': {'comment': 'foocomment'},
- 'ids': [1165434]}
+ 'ids': [1165434]}
diff --git a/tests/data/mockargs/test_bug_apis_setassignee_update.txt b/tests/data/mockargs/test_bug_apis_setassignee_update.txt
@@ -1,4 +1,4 @@
 {'assigned_to': 'foo@example.com',
  'comment': {'comment': 'foocomment'},
  'ids': [1165434],
- 'qa_contact': 'bar@example.com'}
+ 'qa_contact': 'bar@example.com'}
diff --git a/tests/data/mockargs/test_bug_apis_setstatus_update.txt b/tests/data/mockargs/test_bug_apis_setstatus_update.txt
@@ -1,3 +1,3 @@
 {'comment': {'comment': 'foocomment', 'is_private': True},
  'ids': [1165434],
- 'status': 'POST'}
+ 'status': 'POST'}
diff --git a/tests/data/mockargs/test_bug_fields.txt b/tests/data/mockargs/test_bug_fields.txt
@@ -1 +1 @@
-{'include_fields': ['name'], 'names': ['bug_status']}
+{'include_fields': ['name'], 'names': ['bug_status']}
diff --git a/tests/data/mockargs/test_externalbugs_add.txt b/tests/data/mockargs/test_externalbugs_add.txt
@@ -5,4 +5,4 @@
                     'ext_status': 'CLOSED',
                     'ext_type_description': 'some-bug-add-description',
                     'ext_type_id': 'launchpad',
-                    'ext_type_url': 'https://example.com/launchpad/1234'}]}
+                    'ext_type_url': 'https://example.com/launchpad/1234'}]}
diff --git a/tests/data/mockargs/test_externalbugs_remove.txt b/tests/data/mockargs/test_externalbugs_remove.txt
@@ -3,4 +3,4 @@
  'ext_type_description': 'foo-desc',
  'ext_type_id': 'footype',
  'ext_type_url': 'foo-url',
- 'ids': ['remove1']}
+ 'ids': ['remove1']}
diff --git a/tests/data/mockargs/test_externalbugs_update.txt b/tests/data/mockargs/test_externalbugs_update.txt
@@ -6,4 +6,4 @@
  'ext_type_description': 'some-bug-update',
  'ext_type_id': 'mozilla',
  'ext_type_url': 'https://mozilla.foo/bar/5678',
- 'ids': ['external1', 'external2']}
+ 'ids': ['external1', 'external2']}
diff --git a/tests/data/mockargs/test_info_components-active.txt b/tests/data/mockargs/test_info_components-active.txt
@@ -1,2 +1,2 @@
 {'include_fields': ['name', 'id', 'components.name', 'components.is_active'],
- 'names': ['test-fake-product']}
+ 'names': ['test-fake-product']}
diff --git a/tests/data/mockargs/test_info_components-legalvalues.txt b/tests/data/mockargs/test_info_components-legalvalues.txt
@@ -1 +1 @@
-{'field': 'component', 'product_id': 7}
+{'field': 'component', 'product_id': 7}
diff --git a/tests/data/mockargs/test_info_components-owners.txt b/tests/data/mockargs/test_info_components-owners.txt
@@ -2,4 +2,4 @@
                     'id',
                     'components.name',
                     'components.default_assigned_to'],
- 'names': ['test-fake-product']}
+ 'names': ['test-fake-product']}
diff --git a/tests/data/mockargs/test_info_components.txt b/tests/data/mockargs/test_info_components.txt
@@ -1,2 +1,2 @@
 {'include_fields': ['name', 'id', 'components.name'],
- 'names': ['test-fake-product']}
+ 'names': ['test-fake-product']}
diff --git a/tests/data/mockargs/test_info_products.txt b/tests/data/mockargs/test_info_products.txt
@@ -1 +1 @@
-{'ids': [1, 7], 'include_fields': ['name', 'id']}
+{'ids': [1, 7], 'include_fields': ['name', 'id']}
diff --git a/tests/data/mockargs/test_info_versions.txt b/tests/data/mockargs/test_info_versions.txt
@@ -1 +1 @@
-{'include_fields': ['name', 'id', 'versions'], 'names': ['test-fake-product']}
+{'include_fields': ['name', 'id', 'versions'], 'names': ['test-fake-product']}
diff --git a/tests/data/mockargs/test_interactive_login.txt b/tests/data/mockargs/test_interactive_login.txt
@@ -1 +1 @@
-{'login': 'fakeuser', 'password': 'fakepass'}
+{'login': 'fakeuser', 'password': 'fakepass'}
diff --git a/tests/data/mockargs/test_login-restrict.txt b/tests/data/mockargs/test_login-restrict.txt
@@ -1 +1 @@
-{'login': 'FOO', 'password': 'BAR', 'restrict_login': True}
+{'login': 'FOO', 'password': 'BAR', 'restrict_login': True}
diff --git a/tests/data/mockargs/test_login.txt b/tests/data/mockargs/test_login.txt
@@ -1 +1 @@
-{'login': 'FOO', 'password': 'BAR'}
+{'login': 'FOO', 'password': 'BAR'}
diff --git a/tests/data/mockargs/test_modify1.txt b/tests/data/mockargs/test_modify1.txt
@@ -1 +1 @@
-{'component': 'NEWCOMP', 'ids': ['123456', '1234567'], 'status': 'ASSIGNED'}
+{'component': 'NEWCOMP', 'ids': ['123456', '1234567'], 'status': 'ASSIGNED'}
diff --git a/tests/data/mockargs/test_modify2.txt b/tests/data/mockargs/test_modify2.txt
@@ -8,4 +8,4 @@
  'keywords': {'add': ['FOO']},
  'resolution': 'DUPLICATE',
  'status': 'CLOSED',
- 'whiteboard': 'thisone'}
+ 'whiteboard': 'thisone'}
diff --git a/tests/data/mockargs/test_modify3-tags.txt b/tests/data/mockargs/test_modify3-tags.txt
@@ -1 +1 @@
-{'ids': ['1165434'], 'tags': {'add': ['addtag'], 'remove': ['rmtag']}}
+{'ids': ['1165434'], 'tags': {'add': ['addtag'], 'remove': ['rmtag']}}
diff --git a/tests/data/mockargs/test_modify3.txt b/tests/data/mockargs/test_modify3.txt
@@ -1,4 +1,4 @@
 {'cf_devel_whiteboard': 'somedeveltag,someothertag devel-duh',
  'cf_internal_whiteboard': 'someinternal TAG internal-hey bar',
  'cf_qa_whiteboard': 'bar baz yo-qa',
- 'ids': [1165434]}
+ 'ids': [1165434]}
diff --git a/tests/data/mockargs/test_modify4.txt b/tests/data/mockargs/test_modify4.txt
@@ -1,4 +1,4 @@
 {'cf_fixed_in': 'foofixedin',
  'component': 'lvm2',
  'ids': ['1165434'],
- 'sub_components': {'lvm2': ['some-sub-component']}}
+ 'sub_components': {'lvm2': ['some-sub-component']}}
diff --git a/tests/data/mockargs/test_new1.txt b/tests/data/mockargs/test_new1.txt
@@ -7,4 +7,4 @@
  'groups': ['FOOGROUP', 'BARGROUP'],
  'keywords': ['ADDKEY'],
  'product': 'FOOPROD',
- 'summary': 'Hey this is the title!'}
+ 'summary': 'Hey this is the title!'}
diff --git a/tests/data/mockargs/test_query1-ids.txt b/tests/data/mockargs/test_query1-ids.txt
@@ -1,4 +1,4 @@
 {'component': ['foo', 'bar'],
  'id': ['1234', '2480'],
  'include_fields': ['id'],
- 'product': ['foo']}
+ 'product': ['foo']}
diff --git a/tests/data/mockargs/test_query1-rhbz.txt b/tests/data/mockargs/test_query1-rhbz.txt
@@ -15,4 +15,4 @@
  'type2-0-0': 'substring',
  'value0-0-0': 'fribkeyword',
  'value1-0-0': 'amifixed',
- 'value2-0-0': 'some-example-whiteboard'}
+ 'value2-0-0': 'some-example-whiteboard'}
diff --git a/tests/data/mockargs/test_query1.txt b/tests/data/mockargs/test_query1.txt
@@ -1,4 +1,4 @@
 {'component': ['foo', 'bar'],
  'id': ['1234', '2480'],
  'include_fields': ['assigned_to', 'id', 'status', 'summary'],
- 'product': ['foo']}
+ 'product': ['foo']}
diff --git a/tests/data/mockargs/test_query2-rhbz.txt b/tests/data/mockargs/test_query2-rhbz.txt
@@ -2,4 +2,4 @@
  'emailcc1': True,
  'emailtype1': 'BAR',
  'include_fields': ['assigned_to', 'id', 'status', 'summary'],
- 'query_format': 'advanced'}
+ 'query_format': 'advanced'}
diff --git a/tests/data/mockargs/test_query2.txt b/tests/data/mockargs/test_query2.txt
@@ -1 +1 @@
-{'id': ['1165434'], 'include_fields': ['id']}
+{'id': ['1165434'], 'include_fields': ['id']}
diff --git a/tests/data/mockargs/test_query3.txt b/tests/data/mockargs/test_query3.txt
@@ -7,4 +7,4 @@
                     'flags_requestee',
                     'foo',
                     'whiteboard',
-                    'id']}
+                    'id']}
diff --git a/tests/data/mockargs/test_query4.txt b/tests/data/mockargs/test_query4.txt
@@ -13,4 +13,4 @@
                     'depends_on',
                     'id',
                     'status',
-                    'summary']}
+                    'summary']}
diff --git a/tests/data/mockargs/test_query5.txt b/tests/data/mockargs/test_query5.txt
@@ -7,4 +7,4 @@
                     'qa_whiteboard',
                     'status',
                     'summary',
-                    'whiteboard']}
+                    'whiteboard']}
diff --git a/tests/data/mockargs/test_query6.txt b/tests/data/mockargs/test_query6.txt
@@ -8,4 +8,4 @@
                     'keywords',
                     'status',
                     'target_milestone',
-                    'id']}
+                    'id']}
diff --git a/tests/data/mockargs/test_query7.txt b/tests/data/mockargs/test_query7.txt
@@ -12,4 +12,4 @@
  'include_fields': ['assigned_to', 'id', 'status', 'summary'],
  'order': 'bug_status,bug_id',
  'product': 'Fedora',
- 'query_format': 'advanced'}
+ 'query_format': 'advanced'}
diff --git a/tests/data/mockargs/test_query_cve_getbug.txt b/tests/data/mockargs/test_query_cve_getbug.txt
@@ -1 +1 @@
-{'ids': [123456]}
+{'ids': [123456]}
diff --git a/tests/data/mockargs/test_update_flags.txt b/tests/data/mockargs/test_update_flags.txt
@@ -1 +1 @@
-{'flags': {'name': 'needinfo', 'status': '?'}, 'ids': [12345, 6789]}
+{'flags': {'name': 'needinfo', 'status': '?'}, 'ids': [12345, 6789]}
diff --git a/tests/utils.py b/tests/utils.py
@@ -50,6 +50,8 @@ def diff_compare(inputdata, filename):
     actual_out = inputdata
     if isinstance(inputdata, dict):
         actual_out = pprint.pformat(inputdata, width=81)
+    if not actual_out.endswith("\n"):
+        actual_out += "\n"
 
     if not os.path.exists(filename) or tests.CLICONFIG.REGENERATE_OUTPUT:
         open(filename, "w").write(actual_out)

-Original file line number
+Diff line change
  'default_cc': '[email protected]',
  'default_qa_contact': '[email protected]',
  'is_active': 0,
 - 'product': 'fooproduct'}
 + 'product': 'fooproduct'}
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{'exclude_fields': 'foo', 'ids': ['CVE-1234-5678']}`
	`1`	`+{'exclude_fields': 'foo', 'ids': ['CVE-1234-5678']}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{'login': None, 'password': None}`
	`1`	`+{'login': None, 'password': None}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{'include_fields': ['name', 'id'], 'names': ['test-fake-product']}`
	`1`	`+{'include_fields': ['name', 'id'], 'names': ['test-fake-product']}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{'include_fields': ['name', 'id', 'components'], 'names': ['test-fake-product']}`
	`1`	`+{'include_fields': ['name', 'id', 'components'], 'names': ['test-fake-product']}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{'exclude_fields': ['product.foo'], 'ids': ['7']}`
	`1`	`+{'exclude_fields': ['product.foo'], 'ids': ['7']}`