transport: Centralize XMLRPC method+args logging

crobinso · crobinso · commit 1fbc3e21659f · 2018-08-10T17:23:37.000-04:00
diff --git a/bugzilla/base.py b/bugzilla/base.py
@@ -748,7 +748,6 @@ def product_get(self, ids=None, names=None,
         if exclude_fields:
             kwargs["exclude_fields"] = exclude_fields
 
-        log.debug("Calling Product.get with: %s", kwargs)
         ret = self._proxy.Product.get(kwargs)
         return ret['products']
 
@@ -874,7 +873,6 @@ def getcomponents(self, product, force_refresh=False):
             product_id = proddict["id"]
 
             opts = {'product_id': product_id, 'field': 'component'}
-            log.debug("Calling Bug.legal_values with: %s", opts)
             names = self._proxy.Bug.legal_values(opts)["values"]
             self._cache.component_names[product_id] = names
 
@@ -926,7 +924,6 @@ def addcomponent(self, data):
         '''
         data = data.copy()
         self._component_data_convert(data)
-        log.debug("Calling Component.create with: %s", data)
         return self._proxy.Component.create(data)
 
     def editcomponent(self, data):
@@ -938,7 +935,6 @@ def editcomponent(self, data):
         '''
         data = data.copy()
         self._component_data_convert(data, update=True)
-        log.debug("Calling Component.update with: %s", data)
         return self._proxy.Component.update(data)
 
 
@@ -1023,7 +1019,6 @@ def _getbugs(self, idlist, permissive,
         getbugdata.update(self._process_include_fields(
             include_fields, exclude_fields, extra_fields))
 
-        log.debug("Calling Bug.get with: %s", getbugdata)
         r = self._proxy.Bug.get(getbugdata)
 
         if self._check_version(4, 0):
@@ -1251,7 +1246,6 @@ def query(self, query):
         Also see the _query() method for details about the underlying
         implementation.
         '''
-        log.debug("Calling Bug.search with: %s", query)
         try:
             r = self._proxy.Bug.search(query)
         except Fault as e:
@@ -1307,7 +1301,6 @@ def update_bugs(self, ids, updates):
         tmp = updates.copy()
         tmp["ids"] = self._listify(ids)
 
-        log.debug("Calling Bug.update with: %s", tmp)
         return self._proxy.Bug.update(tmp)
 
     def update_tags(self, idlist, tags_add=None, tags_remove=None):
@@ -1325,7 +1318,6 @@ def update_tags(self, idlist, tags_add=None, tags_remove=None):
             "tags": tags,
         }
 
-        log.debug("Calling Bug.update_tags with: %s", d)
         return self._proxy.Bug.update_tags(d)
 
     def update_flags(self, idlist, flags):
@@ -1592,7 +1584,6 @@ def updateattachmentflags(self, bugid, attachid, flagname, **kwargs):
         flags.update(kwargs)
         update = {'ids': [int(attachid)], 'flags': [flags]}
 
-        log.debug("Calling Bug.update_attachment(%s)", update)
         return self._proxy.Bug.update_attachment(update)
 
     def get_attachments(self, ids, attachment_ids,
@@ -1614,7 +1605,6 @@ def get_attachments(self, ids, attachment_ids,
         if exclude_fields:
             params["exclude_fields"] = self._listify(exclude_fields)
 
-        log.debug("Calling Bug.attachments(%s)", params)
         return self._proxy.Bug.attachments(params)
 
 
@@ -1727,7 +1717,6 @@ def createbug(self, *args, **kwargs):
         be passed.
         '''
         data = self._validate_createbug(*args, **kwargs)
-        log.debug("Calling Bug.create with: %s", data)
         rawbug = self._proxy.Bug.create(data)
         return Bug(self, bug_id=rawbug["id"],
                    autorefresh=self.bug_autorefresh)
@@ -1764,7 +1753,6 @@ def _getusers(self, ids=None, names=None, match=None):
             raise BugzillaError('_get() needs one of ids, '
                                 ' names, or match kwarg.')
 
-        log.debug("Calling User.get with: %s", params)
         return self._proxy.User.get(params)
 
     def getuser(self, username):
@@ -1845,5 +1833,4 @@ def updateperms(self, user, action, groups):
             }
         }
 
-        log.debug("Call User.update with: %s", update)
         return self._proxy.User.update(update)
diff --git a/bugzilla/transport.py b/bugzilla/transport.py
@@ -88,6 +88,8 @@ def _ServerProxy__request(self, methodname, params):
         if len(params) == 0:
             params = ({}, )
 
+        log.debug("XMLRPC call: %s(%s)", methodname, params[0])
+
         if self.api_key is not None:
             if 'Bugzilla_api_key' not in params[0]:
                 params[0]['Bugzilla_api_key'] = self.api_key
