base: Fix implied disconnect() on connect() call

crobinso · crobinso · commit 1a6bf48c273e · 2017-02-16T09:23:41.000-05:00
Apparently we can't check self._proxy like that, since it tries to look up data on the remote connection. Check self._transport instead, and add a test case. https://lists.fedoraproject.org/archives/list/python-bugzilla@lists.fedorahosted.org/message/MEXHTFZLHXFVFA3DDRYPISMNZNFX4RER/
diff --git a/bugzilla/base.py b/bugzilla/base.py
@@ -486,7 +486,7 @@ def connect(self, url=None):
         If 'user' and 'password' are both set, we'll run login(). Otherwise
         you'll have to login() yourself before some methods will work.
         '''
-        if self._proxy:
+        if self._transport:
             self.disconnect()
 
         if url is None and self.url:
diff --git a/tests/ro_functional.py b/tests/ro_functional.py
@@ -248,6 +248,10 @@ class RHTest(BaseTest):
     test14 = lambda s: BaseTest._testQueryOneline(s, "720784",
             " CVE-2011-2527")
 
+    def testDoubleConnect(self):
+        bz = self.bzclass(url=self.url)
+        bz.connect(self.url)
+
     def testQueryFlags(self):
         bz = self.bzclass(url=self.url)
         if not bz.logged_in:
