cli: Add modify --minor-update option

crobinso · crobinso · commit 14849bde351d · 2020-10-03T15:04:45.000-04:00
This adds support for the minor_update bugzilla option that is in bugzilla.git: bugzilla/bugzilla@1d96fa1 It disables sending email notifications for the bug change Resolves: #94 Signed-off-by: Cole Robinson <crobinso@redhat.com>
diff --git a/bugzilla/_cli.py b/bugzilla/_cli.py
@@ -231,6 +231,10 @@ def _parser_add_bz_fields(rootp, command):
     p.add_argument('--cc', action="append", help="CC list")
     p.add_argument('-a', '--assigned_to', '--assignee', help="Bug assignee")
     p.add_argument('-q', '--qa_contact', help='QA contact')
+    if cmd_modify:
+        p.add_argument("--minor-update", action="store_true",
+                help="Request bugzilla to not send any "
+                     "email about this change")
 
     if not cmd_new:
         p.add_argument('-f', '--flag', action='append',
@@ -1028,6 +1032,8 @@ def _do_modify(bz, parser, opt):
         update_opts["flags"] = flags
     if opt.comment_tag:
         update_opts["comment_tags"] = opt.comment_tag
+    if opt.minor_update:
+        update_opts["minor_update"] = opt.minor_update
 
     update = bz.build_update(**update_opts)
 
diff --git a/bugzilla/base.py b/bugzilla/base.py
@@ -1444,7 +1444,8 @@ def build_update(self,
                      internal_whiteboard=None,
                      sub_component=None,
                      flags=None,
-                     comment_tags=None):
+                     comment_tags=None,
+                     minor_update=None):
         """
         Returns a python dict() with properly formatted parameters to
         pass to update_bugs(). See bugzilla documentation for the format
@@ -1531,6 +1532,7 @@ def c(val):
         s("work_time", work_time, float)
         s("flags", flags)
         s("comment_tags", comment_tags, listify)
+        s("minor_update", minor_update, bool)
 
         add_dict("blocks", blocks_add, blocks_remove, blocks_set,
                  convert=int)
diff --git a/man/bugzilla.rst b/man/bugzilla.rst
@@ -396,6 +396,10 @@ Reset assignee to component default
 
 Reset QA contact to component default
 
+- ``--minor-update``
+
+Request bugzilla to not send any email about this change
+
 
 &lsquo;new&rsquo; specific options
 ======================
diff --git a/tests/data/mockargs/test_modify5.txt b/tests/data/mockargs/test_modify5.txt
@@ -11,6 +11,7 @@
   'depends_on': {'add': [2234], 'remove': [2235], 'set': []},
   'groups': {'add': ['foogroup']},
   'keywords': {'add': ['newkeyword'], 'remove': ['byekeyword'], 'set': []},
+  'minor_update': True,
   'op_sys': 'windows',
   'platform': 'mips',
   'priority': 'high',
diff --git a/tests/test_cli_modify.py b/tests/test_cli_modify.py
@@ -85,6 +85,7 @@ def test_modify(run_cli):
     cmd += "--devel_whiteboard =DEVBOARD --internal_whiteboard =INTBOARD "
     cmd += "--qa_whiteboard =QABOARD "
     cmd += "--comment-tag FOOTAG --field bar=foo "
+    cmd += "--minor-update "
     fakebz = tests.mockbackend.make_bz(rhbz=True,
         bug_update_args="data/mockargs/test_modify5.txt",
         bug_update_return={})
diff --git a/tests/test_rw_functional.py b/tests/test_rw_functional.py
@@ -96,7 +96,7 @@ def test03NewBugBasic(run_cli, backends):
     assert hasattr(bug, "bug_id")
 
     # Close the bug
-    run_cli("bugzilla modify --close NOTABUG %s" % bug.id, bz)
+    run_cli("bugzilla modify --close NOTABUG %s --minor-update" % bug.id, bz)
     bug.refresh()
     assert bug.status == "CLOSED"
     assert bug.resolution == "NOTABUG"
