Skip to content

Commit 147a654

Browse files
committed
Remove NovellBugzilla
A Novell person hasn't touched this code in 4 years. I can't get it to work. And future changes are about to break things even more. I'm happy to help anyone revive this code if need be, but for now I'm dropping it. git will make it trivial to revive if needed.
1 parent 6d1bfe8 commit 147a654

3 files changed

Lines changed: 5 additions & 192 deletions

File tree

bugzilla/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,14 @@
2121
from bugzilla.base import BugzillaError
2222
from bugzilla.bugzilla3 import Bugzilla3, Bugzilla32, Bugzilla34, Bugzilla36
2323
from bugzilla.bugzilla4 import Bugzilla4, Bugzilla42, Bugzilla44
24-
from bugzilla.nvlbugzilla import NovellBugzilla
2524
from bugzilla.rhbugzilla import RHBugzilla, RHBugzilla3, RHBugzilla4
2625

2726

27+
# Back compat for deleted NovellBugzilla
28+
class NovellBugzilla(Bugzilla34):
29+
pass
30+
31+
2832
def getBugzillaClassForURL(url):
2933
url = Bugzilla3.fix_url(url)
3034
log.debug("Detecting subclass for %s" % url)

bugzilla/nvlbugzilla.py

Lines changed: 0 additions & 170 deletions
This file was deleted.

tests/ro_functional.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -164,27 +164,6 @@ class BZ42(BaseTest):
164164
"3450 [email protected] Error")
165165

166166

167-
class NovellBugzilla(BaseTest):
168-
url = "https://bugzilla.novell.com/xmlrpc.cgi"
169-
bzclass = bugzilla.NovellBugzilla
170-
171-
test0 = BaseTest._testBZClass
172-
173-
test1 = lambda s: BaseTest._testQuery(s,
174-
"--product \"openSUSE 11.0\" --component Basesystem",
175-
15, "83209")
176-
177-
def testLoginFail(self):
178-
# Currently gives a 404 error, so something is busted.
179-
# However if I drop all the custom stuff plain ol BZ login works
180-
bz = self.bzclass(url=self.url, cookiefile=None)
181-
try:
182-
bz.login("foouser", "barpassword")
183-
raise AssertionError("Expected novell login fail")
184-
except Exception, e:
185-
self.assertTrue("404" in str(e))
186-
187-
188167
class RHTest(BaseTest):
189168
url = "https://bugzilla.redhat.com/xmlrpc.cgi"
190169
bzclass = bugzilla.RHBugzilla

0 commit comments

Comments
 (0)