Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-adaptive/adaptive-triangulation
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: python-adaptive/adaptive-triangulation
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: issue-096-impl
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 13 files changed
  • 1 contributor

Commits on Apr 5, 2026

  1. feat: add Rust-powered Learner1D with PyO3 bindings

    Implement a 1D adaptive sampling learner backed by BTreeMap/BTreeSet
    internals, matching the semantics of Python's adaptive.Learner1D.
    
    - Core Learner1D with tell/tell_pending/tell_many/ask/run methods
    - LossManager priority queue with O(1) interval lookup + sorted access
    - Built-in loss functions: Default, Uniform, Resolution, Curvature,
      Triangle, AbsMinLog, and Python callback support
    - 44 comprehensive Python tests covering all functionality
    - Python benchmark script for performance measurement
    basnijholt committed Apr 5, 2026
    Configuration menu
    Copy the full SHA
    28fb2f0 View commit details
    Browse the repository at this point in the history
  2. fix: address code review findings for Rust Learner1D (ISSUE-096)

    - Replace .expect() with error handling in python_callback_loss (CRITICAL)
    - Store out-of-bounds data separately to prevent neighbor query pollution (HIGH)
    - Keep x_scale constant as bounds span, not derived from data (HIGH)
    - Expose loss(real) parameter in PyO3 binding (MEDIUM)
    - Fix empty learner linspace to include right endpoint (MEDIUM)
    - Add interval-based tiebreaking in ask() loss comparison (MEDIUM)
    - Use iterator .any() for has_missing_bounds instead of Vec allocation (LOW)
    - Avoid cloning in rebuild_scale via free function (LOW)
    - Add 12 new tests covering OOB tells, callback exceptions, loss(real=False)
    basnijholt committed Apr 5, 2026
    Configuration menu
    Copy the full SHA
    ca78630 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2026

  1. Configuration menu
    Copy the full SHA
    7103fc1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67c15e1 View commit details
    Browse the repository at this point in the history
Loading