This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Improve integrate_bands performance#263
Open
marksdestiny wants to merge 1 commit intopython-acoustics:masterfrom
Open
Improve integrate_bands performance#263marksdestiny wants to merge 1 commit intopython-acoustics:masterfrom
marksdestiny wants to merge 1 commit intopython-acoustics:masterfrom
Conversation
Reduce the memory consumption and improve the performance when using the integrate_bands function on large signals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly reduce the memory consumption and improve the performance when using the
acoustics.signal.integrate_bandsfunction (used by theacoustics.signal.third_octavesfunction).This is especially important when there are several millions of samples. The memory consumption can be several GB!