Skip to content

Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py - #97

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
hegjon:sdist-test
Nov 25, 2022
Merged

Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py#97
JelleZijlstra merged 3 commits into
python:mainfrom
hegjon:sdist-test

Conversation

@hegjon

@hegjon hegjon commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Before

typing_extensions on  main via 🐍 v3.10.8
❯ python3 -m build .
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for wheel...
* Building wheel...
Successfully built typing_extensions-4.4.0.tar.gz and typing_extensions-4.4.0-py3-none-any.whl

typing_extensions on  main via 🐍 v3.10.8 took 4s
❯ tar tzf dist/typing_extensions-4.4.0.tar.gz
typing_extensions-4.4.0/CHANGELOG.md
typing_extensions-4.4.0/LICENSE
typing_extensions-4.4.0/README.md
typing_extensions-4.4.0/pyproject.toml
typing_extensions-4.4.0/src/test_typing_extensions.py
typing_extensions-4.4.0/src/typing_extensions.py
typing_extensions-4.4.0/PKG-INFO

After

typing_extensions on  sdist-test via 🐍 v3.10.8
❯ python3 -m build .
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for wheel...
* Building wheel...
Successfully built typing_extensions-4.4.0.tar.gz and typing_extensions-4.4.0-py3-none-any.whl

typing_extensions on  sdist-test via 🐍 v3.10.8 took 4s
❯ tar tzf dist/typing_extensions-4.4.0.tar.gz
typing_extensions-4.4.0/CHANGELOG.md
typing_extensions-4.4.0/LICENSE
typing_extensions-4.4.0/README.md
typing_extensions-4.4.0/pyproject.toml
typing_extensions-4.4.0/src/_typed_dict_test_helper.py
typing_extensions-4.4.0/src/test_typing_extensions.py
typing_extensions-4.4.0/src/typing_extensions.py
typing_extensions-4.4.0/PKG-INFO

@ghost

ghost commented Nov 24, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@hegjon hegjon changed the title Expand the include expression to include src/_typed_dict_test_helper.py Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py Nov 24, 2022
@hegjon hegjon mentioned this pull request Nov 24, 2022
Closed
@JelleZijlstra

JelleZijlstra commented Nov 25, 2022

Copy link
Copy Markdown
Member

The CI failures are a little mysterious but seem unrelated to this change. I don't have time right now to investigate though.

The change in the PR looks good, thanks!

@hegjon

hegjon commented Nov 25, 2022

Copy link
Copy Markdown
Contributor Author

Yes, the CI seems to fail during setup and not for this PR

@AlexWaygood AlexWaygood reopened this Nov 25, 2022
@AlexWaygood

AlexWaygood commented Nov 25, 2022

Copy link
Copy Markdown
Member

This might be related: https://twitter.com/hynek/status/1596039449909264385?s=20&t=6k0Z5-nKmqIpXT25e0G-mg

@hegjon

hegjon commented Nov 25, 2022

Copy link
Copy Markdown
Contributor Author

Did a new tiny PR #98 to see if the same CI issues happens on that too

@hegjon

hegjon commented Nov 25, 2022

Copy link
Copy Markdown
Contributor Author

This might be related: https://twitter.com/hynek/status/1596039449909264385?s=20&t=6k0Z5-nKmqIpXT25e0G-mg

Maybe ubuntu-latest changed from 20.04 to 22.04?

@hegjon

hegjon commented Nov 25, 2022

Copy link
Copy Markdown
Contributor Author

Made issue #99 with more details

@JelleZijlstra JelleZijlstra mentioned this pull request Nov 25, 2022
Closed
@JelleZijlstra
JelleZijlstra merged commit 0ea104b into python:main Nov 25, 2022
@hegjon
hegjon deleted the sdist-test branch November 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@hegjon @JelleZijlstra @AlexWaygood