Backport generic NamedTuple and TypedDict support #7

Activity

1. JelleZijlstra

   added

   topic: typing-extensions

   on May 3, 2022
2. AlexWaygood commented on May 3, 2022

   

   AlexWaygood

   on May 3, 2022

   Member

   More actions

   I'd be interested in working on this if nobody else wants to, but I've got quite a lot on for the next two weeks or so, so I'm happy to let somebody else tackle it if they can do it more promptly!

   👍React with 👍7Reacted by Jelle Zijlstra, Thomas Grainger, 93578237, Mehdi Drissi, Ozair Patel, Ken Jin and Thomas M Kehrenberg
3. Bluenix2 commented on May 14, 2022

   

   Bluenix2

   on May 14, 2022

   Last edited by Bluenix2

   More actions

   As discovered in Python Discord's #type-hinting channel (09/05/2022), typing_extensions 4.2 release appears to support this already.

   That said, it appears to still be missing for Python 3.7 and 3.8. This CI run of mine is on Python 3.7 and locally I can reproduce it on my Python 3.8.10 installaton (py -3.8-64 -c "import discord_typings"):

   Traceback (most recent call last):
     File "<string>", line 1, in <module>
     File "C:\Users\%username%\Projects\discord-typings\discord_typings\__init__.py", line 5, in <module> 
       from .gateway import *
     File "C:\Users\%username%\Projects\discord-typings\discord_typings\gateway.py", line 267, in <module>
       ReadyEvent = GenericDispatchEvent[Literal['READY'], ReadyData]
   TypeError: '_TypedDictMeta' object is not subscriptable
   
4. JelleZijlstra commented on May 16, 2022

   

   JelleZijlstra

   on May 16, 2022

   MemberAuthor

   More actions

   The current support is accidental, not tested, and doesn't cover all supported Python versions, so I don't think it really makes a difference.
5. Bluenix2 commented on May 16, 2022

   

   Bluenix2

   on May 16, 2022

   More actions

   It gives hints as to what one could do to make this pass on all versions ☝️
6. JelleZijlstra

   transferred this issue frompython/typingon May 19, 2022
7. JelleZijlstra

   closed this as completedin #46on May 27, 2022
8. julien-blanchon commented on Jun 7, 2023

   

   julien-blanchon

   on Jun 7, 2023

   More actions

   I love this ! I hope TypedDict will also be include soon. Thanks you @JelleZijlstra @AlexWaygood