Repository navigation
Add caching to the new GHA workflow - #880
Merged
Merged
Conversation
…all with flake8 install
srittau
reviewed
Aug 31, 2021
| python -m pip install --upgrade pip | ||
| pip install -r test-requirements.txt | ||
| pip install --upgrade pip | ||
| pip install flake8 |
Collaborator
There was a problem hiding this comment.
We are also installing flake8-bugbear (and flake8-pyi, which shouldn't matter). To avoid this kind of discrepancies, I'd prefer to continue using test-requirements.txt here, even if it installs some unneeded packages.
Contributor
Author
There was a problem hiding this comment.
I see! I'll add caching here instead then 🙂
srittau
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This might be a bit of a premature optimisation, but I noticed you were transitioning to Github actions and I thought I'd propose adding caching to your current workflow 🙂 I also took the liberty of making two other minor changes which I'm happy to drop if you'd rather not include them - just let me know!
I don't think this should introduce any conflicts with #876, but if that PR is merged first, I could rebase and add caching to that job too, if that's something you want (or the other way around hehe) 👍