Repository navigation
Fix and clean up CI script - #876
Merged
Merged
Conversation
* Split Python 2.7 tests from Python 3 tests as they use different paths and require installation of the typing module. * Split running typing and typing_extensions tests into two steps. * Run the typing test step only on Python < 3.7.
srittau
marked this pull request as ready for review
August 30, 2021 22:24
Collaborator
Author
|
Ready for review. I'm unsure why the 3.10 fails, but at least the CI script is now cleaner, and it fails in a test that it should actually run, not in the typing test, so this PR is an improvement. I will have another stab at this tomorrow, if no one beats me to it. |
Member
|
Might be an incompatibility in pytest or pytest-xdist. To get around it we could just stick to unittest. |
* Pin version only for Python 2 * Remove pytest-xdist and pytest-cov not necessary here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.