Repository navigation
Update sqlalchemy stubs - #857
Merged
Merged
Conversation
… Changed sqlalchemy/util/compat.pyi:37 to typing.Text
…ncomplete stub for class third_party/2and3/sqlalchemy/sql/elements/ColumnElement
WouldYouKindly
changed the title
Member
This was referenced Jan 23, 2017
Closed
Contributor
Author
|
@gvanrossum Yes. I'm hoping to send a PR before/on the weekend. |
ambv
reviewed
Jan 24, 2017
| foreign_keys = [] # type: Any | ||
| _label = None | ||
| _key_label = key = None | ||
| _alt_names = () |
Contributor
There was a problem hiding this comment.
Missed variable annotations above are failing mypy's own tests.
Contributor
Author
There was a problem hiding this comment.
Guess I'll just annotate them with Any for now... I'll submit a PR in a few days.
Contributor
There was a problem hiding this comment.
I already did, no worries! Just keep this in mind for future PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this covers both 647 and 719.
Moved sqlalchemy stubs from 2 to 2and3;
changed sqlalchemy/util/compat.pyi:37 to be of type typing.Text;
added incomplete stubs for sqlalchemy.orm.utils and slqalchemy.sql.elements.ColumnElement.