Repository navigation
Add types for zxcvbn - #8089
Add types for zxcvbn#8089
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
Mostly looks good, but I'm not sure about the huge _Match TypedDict in matching.pyi. It seems like we could probably have a smaller base TypedDict, and return subtypes of that TypedDict from specific functions where _Match always has certain other keys.
Basically everything except the |
Theorically, this supports more types, but I don't think that's important here.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Ideally we'd be able to return |
This comment has been minimized.
This comment has been minimized.
|
What do you want to do here?
|
|
I honestly think, we could just merge it. pytype should just assume |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
No description provided.