Skip to content

random: explicitly mention int for seed - #7916

Merged
hauntsaninja merged 2 commits into
python:masterfrom
hauntsaninja:randint
May 21, 2022
Merged

hauntsaninja merged 2 commits into
python:masterfrom
hauntsaninja:randint

Conversation

@hauntsaninja

Copy link
Copy Markdown
Collaborator

#7906 (comment)
I felt this better documents how seed is used in practice

python#7906 (comment)
I felt this better documents how seed is used in practice

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we added a comment about why we're noqaing , like we do in turtle.pyi, but feel free to merge

@github-actions

This comment has been minimized.

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja
hauntsaninja merged commit f2ea124 into python:master May 21, 2022
@hauntsaninja
hauntsaninja deleted the randint branch May 21, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants