You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add typing._SubscriptableSpecialForm and use it to fix various special forms - #7509
Thanks, but I agree with @JelleZijlstra that we need to be very careful with changes to typing. Personally, I'm open to #7508, as it seems to be solving an actual problem, and is a much smaller change. But this change is quite sweeping, and would require adding entries to the stubtest allowlists in order to propagate a lie in typeshed. I'm also not sure how much of a real problem it is that mypy thinks NoReturnand Never are subscriptable. (I suppose you could make more of an argument for TypeAlias or Self, but it still doesn't seem nearly as much of a problem as the typing.Union problem fixed in #7508.)
Note that we reject using Self with type arguments, such as Self[int]. This is because it creates ambiguity about the type of the self parameter and introduces unnecessary complexity
Note that we reject using Self with type arguments, such as Self[int]. This is because it creates ambiguity about the type of the self parameter and introduces unnecessary complexity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
We could lie and make a fake subclass of special form that has
NoReturnon__getitem__😳