Repository navigation
Add mypy error codes to type: ignores, remove unused ignores - #7504
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@hauntsaninja, any idea which config options we're missing from |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
marked this pull request as ready for review
March 17, 2022 10:23
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Mar 19, 2022
Co-authored-by: Jelle Zijlstra <[email protected]>
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Mar 19, 2022
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accomplished with a little help from @Akuli's script in 745da72
This does the uncontroversial bits from #7497 (adds mypy error codes where possible, removes the unused ignores, highlights which ignores are pyright-specific). We can carry on discussing in the issue thread whether we want to change the pyright-specific
type: ignores to use the newpyright: ignorecomments instead.