Skip to content

pyright: Don't report incompatible overrides - #7498

Merged
srittau merged 1 commit into
python:masterfrom
srittau:ignore-warning
Mar 16, 2022
Merged

pyright: Don't report incompatible overrides#7498
srittau merged 1 commit into
python:masterfrom
srittau:ignore-warning

Conversation

@srittau

@srittau srittau commented Mar 16, 2022

Copy link
Copy Markdown
Collaborator

These overrides are inherited from the implementation and are out of
typeshed's control.

@srittau
pyright: Don't report incompatible overrides
b0bd84b 
These overrides are inherited from the implementation and are out of
typeshed's control.
@srittau

srittau commented Mar 16, 2022

Copy link
Copy Markdown
Collaborator Author

See discussion in #7495.

AlexWaygood
AlexWaygood approved these changes Mar 16, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I assume the CI will pass, if it ever wakes up from its slumber)

@srittau srittau closed this Mar 16, 2022
@srittau srittau reopened this Mar 16, 2022
@srittau
srittau merged commit 108b6fb into python:master Mar 16, 2022
@srittau
srittau deleted the ignore-warning branch March 16, 2022 15:20
@JelleZijlstra

JelleZijlstra commented Mar 16, 2022

Copy link
Copy Markdown
Member

We should be able to do this for mypy too by turning off the override error code.

Not totally sure we should do this, though; often incompatible override errors can be ignored, but sometimes they also provide a useful nudge to adjust the annotations on a method that's part of a protocol.

@AlexWaygood

AlexWaygood commented Mar 16, 2022

Copy link
Copy Markdown
Member

We should be able to do this for mypy too by turning off the override error code.

Not totally sure we should do this, though; often incompatible override errors can be ignored, but sometimes they also provide a useful nudge to adjust the annotations on a method that's part of a protocol.

Personally I'm happy with keeping the mypy errors, but switching off the slightly stricter pyright errors? (I think that's a coherent position?)

@AlexWaygood AlexWaygood mentioned this pull request Mar 17, 2022
Closed
@AlexWaygood AlexWaygood mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srittau @JelleZijlstra @AlexWaygood