Repository navigation
Py2 SQLAlchemy: Move some TypeEngine functions from subclasses to TypeEngine - #724
Merged
Merged
Conversation
ambv
requested changes
Nov 30, 2016
| class DateTime(TypeEngine, _DateAffinity): | ||
| def __init__(self, timezone=None): ... | ||
| @property | ||
| def python_type(self): ... |
Contributor
There was a problem hiding this comment.
Actually, instead of here, add this property on TypeEngine, it's defined there and available on all types.
| def __init__(self, timezone=None): ... | ||
| @property | ||
| def python_type(self): ... | ||
| def get_dbapi_type(self, dbapi): ... |
Contributor
There was a problem hiding this comment.
TRManderson
changed the title
Contributor
Author
|
It's not at all clear to me why the build is failing, so I'll just leave this as is for now. |
Member
|
The linter is complaining about these two lines: |
gvanrossum
reviewed
Dec 5, 2016
| @@ -2,6 +2,13 @@ from .. import util | |||
| from .visitors import Visitable, VisitableType | |||
|
|
|||
| class TypeEngine(Visitable): ... | |||
Member
There was a problem hiding this comment.
Need to remove these "..." from this line.
Member
|
(Sorry, it wasn't the linter, it was an actual syntax error. I've explained
it.)
|
Contributor
Author
|
Thanks Guido, that's what I get for making PRs before coffee. Pushing a fix now. |
Member
|
LGTM. @ambv can you do the honors? |
Member
|
I've merged this despite the pending review (over a week old). It seems simple enough. Now we have to see whether this causes a merge conflict with #719... |
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure about:
which is also defined on datetime