Skip to content

[WIP] Sqlalchemy 23 - #719

Closed
aleksanb wants to merge 2 commits into
python:masterfrom
comoyo:sqlalchemy-23
Closed

[WIP] Sqlalchemy 23#719
aleksanb wants to merge 2 commits into
python:masterfrom
comoyo:sqlalchemy-23

Conversation

@aleksanb

@aleksanb aleksanb commented Nov 29, 2016

Copy link
Copy Markdown

Continuation of #647

Still has some issues which need resolving.

@stianjensen

stianjensen commented Dec 8, 2016

Copy link
Copy Markdown

What other issues remain?

@aleksanb

aleksanb commented Dec 9, 2016

Copy link
Copy Markdown
Author

The issues were mainly that when using this version of typeshed for our internal project, new errors unraveled themselves due to other parts of sqlalchemy stubs missing, which i couldn't resolve locally with # type: ignore, so i put the PR on hold.
It might still be better than the current situation, though. But i'd like it if someone else tested this PR as well.

This was referenced Dec 13, 2016
Closed
Merged
@ambv
ambv force-pushed the master branch 10 times, most recently from 63ba0ab to 7853c26 Compare December 23, 2016 00:12
@gvanrossum

gvanrossum commented Jan 9, 2017

Copy link
Copy Markdown
Member

@aleksanb Are you still interested in pursuing this? If so, please rebase and push another version. If we don't hear from you in a few weeks we'll just close this PR without action.

@WouldYouKindly WouldYouKindly mentioned this pull request Jan 22, 2017
Merged
gvanrossum pushed a commit that referenced this pull request Jan 23, 2017
@WouldYouKindly @gvanrossum
Update sqlalchemy stubs (#857)
ccdc609 
I believe this covers both #647 and #719.

Moved sqlalchemy stubs from 2 to 2and3;
changed sqlalchemy/util/compat.pyi:37 to be of type typing.Text;
added incomplete stubs for sqlalchemy.orm.utils and slqalchemy.sql.elements.ColumnElement.
@gvanrossum

gvanrossum commented Jan 23, 2017

Copy link
Copy Markdown
Member

Closed in favor of #857.

@gvanrossum gvanrossum closed this Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@aleksanb @stianjensen @gvanrossum