Skip to content

requests: remove an unused allowlist entry - #6911

Merged
srittau merged 1 commit into
python:masterfrom
Akuli:requests
Jan 13, 2022
Merged

srittau merged 1 commit into
python:masterfrom
Akuli:requests

Conversation

@Akuli

@Akuli Akuli commented Jan 13, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@AlexWaygood

Copy link
Copy Markdown
Member

Looks like a result of #6892.

Kind of annoying that requests is going to randomly fail stubtest every so often due to unrelated changes we make to the urllib stubs.

Would there be a way to make sure stubtest always runs for requests every time a change is made to the urllib stubs, so we're alerted to unused allowlist entries when the PR is being prepared?

@Akuli

Akuli commented Jan 13, 2022

Copy link
Copy Markdown
Collaborator Author

Currently the stubs to be tested in a PR are given by:

STUBS=$(git diff --name-only origin/${{ github.base_ref }} HEAD | egrep ^stubs/ | cut -d "/" -f 2 | sort -u | (while read stub; do [ -d stubs/$stub ] && echo $stub || true; done))

We should probably replace this with a script that takes in account dependencies to types-foo packages specified in METADATA.toml.

@srittau
srittau merged commit df0fe16 into python:master Jan 13, 2022
@Akuli
Akuli deleted the requests branch January 13, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants