Repository navigation
Update urllib3.exceptions stubs - #6865
Merged
Merged
Conversation
srittau
requested changes
Jan 8, 2022
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
AlexWaygood
reviewed
Jan 9, 2022
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
We can just remove the __reduce__ and __repr__ methods from the stub, since the signatures are the same for object.__reduce__ and object.__repr__, and all classes implicitly inherit from object 🙂
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
srittau
approved these changes
Jan 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete implementation of
urllib3.exceptionsfor latest release (1.26.8): https://github.com/urllib3/urllib3/blob/b1f60e44d43b13e5272d5b6003f125af9c25c8ad/src/urllib3/exceptions.pyOriginally I did this in #6794 to update
requests.packages.urllib3.exceptionsbut we're moving this to the urllib3 stubs to remove duplicate work.(Originally this would have closed #6054 which requested the
requests.packages.urllib3.exceptionsbut I think due the odd way they're importing urllib3 in requests I don't think this PR will close that issue)