Skip to content

Use types-urllib3 for requests - #6859

Merged
Akuli merged 6 commits into
python:masterfrom
srittau:requests-urllib
Jan 8, 2022
Merged

Akuli merged 6 commits into
python:masterfrom
srittau:requests-urllib

Conversation

@srittau

@srittau srittau commented Jan 8, 2022

Copy link
Copy Markdown
Collaborator

Mark urllib3 as supporting Python 2

Comment thread stubs/requests/requests/packages/__init__.pyi Outdated
@srittau

srittau commented Jan 8, 2022

Copy link
Copy Markdown
Collaborator Author

#6860 for a check_consistent fix.

Comment thread stubs/requests/METADATA.toml Outdated

@Akuli Akuli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and import changes look correct.

@Akuli
Akuli merged commit f8501d3 into python:master Jan 8, 2022
@srittau
srittau deleted the requests-urllib branch January 8, 2022 14:36
@jpy-git

jpy-git commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

I opened #6794 a couple days back to address #6054 where someone wanted requests/packages/urllib3/exceptions.pyi updated. Given that we've removed that file in this PR, will close #6794 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants