Skip to content

Complete requests.packages.urllib3.exceptions stubs - #6794

Closed
jpy-git wants to merge 3 commits into
python:masterfrom
jpy-git:requests.packages.urllib3.exceptions
Closed

jpy-git wants to merge 3 commits into
python:masterfrom
jpy-git:requests.packages.urllib3.exceptions

Conversation

@jpy-git

@jpy-git jpy-git commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

@jpy-git

jpy-git commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

Closing as decided in #6859 to not type requests/packages/urllib3 files (since it's just duplicating work from urllib3 stubs)

@jpy-git jpy-git closed this Jan 8, 2022
@Akuli

Akuli commented Jan 8, 2022

Copy link
Copy Markdown
Collaborator

The corresponding changes in stubs/urllib3/ would be appreciated :)

@jpy-git

jpy-git commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

The corresponding changes in stubs/urllib3/ would be appreciated :)

Good shout! Those look like they don't have these updates yet so will update those instead 😄

@srittau

srittau commented Jan 8, 2022

Copy link
Copy Markdown
Collaborator

The urllib3 stubs are just of a copy of the requests.packages.urllib3 stubs at the moment, so any improvements are welcome!

@jpy-git

jpy-git commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

Thanks I've made a separate PR #6865 to update the stubs in urllib3.exceptions instead 😄

@jpy-git
jpy-git deleted the requests.packages.urllib3.exceptions branch January 8, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requests.packages.urllib3.exceptions stubs are incomplete (e.g. SNIMissingWarning is missing)

3 participants