Skip to content

Adding PyMySQL and SQLAlchemy stubs for Python 3 - #647

Closed
jhagerer wants to merge 4 commits into
python:masterfrom
jhagerer:master
Closed

Adding PyMySQL and SQLAlchemy stubs for Python 3#647
jhagerer wants to merge 4 commits into
python:masterfrom
jhagerer:master

Conversation

@jhagerer

@jhagerer jhagerer commented Nov 1, 2016

Copy link
Copy Markdown

Stubs were auto-generated and manually modified using mypy/stubgen.py and Python 3.5. Closes the following ticket:

Stubs for PyMySQL #631

Gerhard Hagerer
Adding PyMySQL for Python 3
4530fac 
Stubs were auto-generated and manually modified using mypy/stubgen.py and Python 3.5. Closes the following ticket:

python#631
@jhagerer jhagerer changed the title Adding PyMySQL for Python 3 Adding PyMySQL stubs for Python 3 Nov 1, 2016
Gerhard Hagerer
Delete __init__.pyi
6f0a29d 
tests make problems for mypy
@jhagerer

jhagerer commented Nov 1, 2016

Copy link
Copy Markdown
Author

Deleted a broken stub file

Gerhard Hagerer
added sqlalchemy to third_party/2and3
dd29509 
just changed sqlalchemy/util/compat:37 unicode -> str, everything else is unchanged
@jhagerer

jhagerer commented Nov 2, 2016

Copy link
Copy Markdown
Author

added sqlalchemy to third_party/2and3
just changed sqlalchemy/util/compat:37 unicode -> str, everything else is unchanged

@jhagerer jhagerer changed the title Adding PyMySQL stubs for Python 3 Adding PyMySQL and SQLAlchemy stubs for Python 3 Nov 2, 2016
@gvanrossum

gvanrossum commented Nov 2, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

@ghagerer Did you realize there are already stubs for sqlalchemy in third_party/2/sqlalchemy/? We shouldn't have stubs for the same package in both /2 and /2and3. How do your stubs compare to those?

@gvanrossum gvanrossum mentioned this pull request Nov 4, 2016
Closed
@jhagerer

jhagerer commented Nov 8, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

Both are 100% the same except one line:

sqlalchemy/util/compat.pyi:37:
old: text_type = unicode
new: text_type = str

In that way both mypy and mypy --py2 run without errors.

Should I delete the third_party/2/sqlalchemy folder from my fork and then merge?

@gvanrossum

gvanrossum commented Nov 8, 2016

Copy link
Copy Markdown
Member

That sounds like a good plan. Maybe you can change that type alias to using typing.Text, which does the right thing regardless of Python version.

@aleksanb

aleksanb commented Nov 28, 2016

Copy link
Copy Markdown

Activity seems to have died down, could one of us take over this PR and finish the remaining changes?
(deleting third_party/2/sqlalchemy and using the type alias in the one file).

Looking forward to getting this merged.

@gvanrossum

gvanrossum commented Nov 28, 2016 via email

Copy link
Copy Markdown
Member

@aleksanb aleksanb mentioned this pull request Nov 29, 2016
Closed
@gvanrossum
Update a comment.
761859f 
This is just to trigger the test to run again -- I have reasons to believe this PR is out of date.
@gvanrossum

gvanrossum commented Dec 13, 2016

Copy link
Copy Markdown
Member

Huh, okay, my local tests failed because I forgot to rebase, and everything's fine. But I am still going to close this in favor of #719 (even though the latter is also on hold) since too many competing PRs is just confusing. If I made a mistake please comment here (or on #719) and I'll correct it!

@gvanrossum gvanrossum closed this Dec 13, 2016
@gvanrossum

gvanrossum commented Dec 13, 2016

Copy link
Copy Markdown
Member

Whoops, there are two parts here. One part is the sqlalchemy stubs which IIUC is superseded by #719. But the other part is pymysql which is not there AFAICT. So reopening in the hope of disentangling the two PRs...

@gvanrossum gvanrossum reopened this Dec 13, 2016
@ambv
ambv force-pushed the master branch 10 times, most recently from 63ba0ab to 7853c26 Compare December 23, 2016 00:12
@gvanrossum

gvanrossum commented Jan 9, 2017

Copy link
Copy Markdown
Member

@ghagerer Can I entice you to submit your stubs for pymysql separately? Then hopefully your work on those can be merged. If we don't hear from you in a few weeks we'll close this PR without action.

@WouldYouKindly WouldYouKindly mentioned this pull request Jan 22, 2017
Merged
gvanrossum pushed a commit that referenced this pull request Jan 23, 2017
@WouldYouKindly @gvanrossum
Update sqlalchemy stubs (#857)
ccdc609 
I believe this covers both #647 and #719.

Moved sqlalchemy stubs from 2 to 2and3;
changed sqlalchemy/util/compat.pyi:37 to be of type typing.Text;
added incomplete stubs for sqlalchemy.orm.utils and slqalchemy.sql.elements.ColumnElement.
@gvanrossum

gvanrossum commented Jan 23, 2017

Copy link
Copy Markdown
Member

I'd closed this in favor of #857 except I'm still hopeful to also get the pymysql stubs in.

@WouldYouKindly WouldYouKindly mentioned this pull request Jan 24, 2017
Merged
gvanrossum pushed a commit that referenced this pull request Jan 30, 2017
@WouldYouKindly @gvanrossum
Adding pymysql stubs to third_party/2and3 (#861)
f398628 
(Original by @ghagerer, extracted from #647 by @WouldYouKindly.)
@gvanrossum

gvanrossum commented Jan 30, 2017

Copy link
Copy Markdown
Member

Superseded by #861.

@gvanrossum gvanrossum closed this Jan 30, 2017
hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
@ilevkivskyi
Add support for Python 3.8 in typing_extensions (python#647)
4064a6d 
Fixes python/typing#643

(Use ignore whitespace option to review this, since it mostly just indents a bunch of stuff.)

PR summary:
* Update Travis config to run on a bunch of newer Python versions (including 3.8-dev).
* Only run `typing` tests on Python 3.6 or older, starting from Python 3.7 development of `typing` moved to CPython repo, where it was significantly reworked. We still run `typing_extension` tests on all versions.
* Update `repr()` tests in `typing_extensions` to conditionally expect correct module name.
* Add `TypedDict` to `__all__`.
* Use `Final`, `Literal`, etc. from `typing` if those are available (as we do for other things).
* Rename `@runtime` to `@runtime_checkable` in `typing_extensions` (I think we can keep `@runtime` in `typing_extensions` as an alias for backwards compatibility).

Note this only updates Python 3 version of `typing_extensions`. There will be a corresponding update for the Python 2 version of `typing_extensions` as part of python/typing#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@jhagerer @gvanrossum @aleksanb