Skip to content

Fix allowlists - #6440

Merged
hauntsaninja merged 1 commit into
python:masterfrom
hauntsaninja:allow
Nov 29, 2021
Merged

Fix allowlists#6440
hauntsaninja merged 1 commit into
python:masterfrom
hauntsaninja:allow

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Nov 29, 2021

Copy link
Copy Markdown
Collaborator

Broken by #6439

JelleZijlstra
JelleZijlstra approved these changes Nov 29, 2021
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this happened?

@hauntsaninja

hauntsaninja commented Nov 29, 2021

Copy link
Copy Markdown
Collaborator Author

Yeah, #6408 meant dummy_threading was an unused allowlist for py39 and py310, which made the action remove it. Last I checked, Github Actions doesn't allow running Github Actions on Github Actions, so CI didn't run on #6439. This kind of thing has happened several times before.

@hauntsaninja
hauntsaninja merged commit 287a9a4 into python:master Nov 29, 2021
@hauntsaninja
hauntsaninja deleted the allow branch November 29, 2021 04:18
@Akuli

Akuli commented Nov 29, 2021

Copy link
Copy Markdown
Collaborator

I came across this in #6424 before #6439 existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hauntsaninja @Akuli @JelleZijlstra