Skip to content

stubtest_stdlib: fail if there are unused allowlist entries #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 8 commits into from
Dec 1, 2021
Merged

stubtest_stdlib: fail if there are unused allowlist entries #6424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8eecadd
stubtest_stdlib: fail if there are unused allowlist entries
Akuli Nov 28, 2021
1265cb4
improve print
Akuli Nov 28, 2021
4cf57c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2021
151fe48
Remove unused stubtest allowlist entries
Akuli Nov 28, 2021
e0ff3ac
add _dummy_threading exclude back manually
Akuli Nov 28, 2021
b9fc480
Merge remote-tracking branch 'origin/master' into fail-unused
Akuli Nov 29, 2021
25cde81
Merge remote-tracking branch 'origin/master' into fail-unused
Akuli Dec 1, 2021
58306fe
manually remove logging __init__ allowlist entries
Akuli Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions .github/workflows/stubtest-unused-allowlist.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/stubtest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Install dependencies
run: pip install $(grep tomli== requirements-tests-py3.txt) $(grep mypy== requirements-tests-py3.txt)
- name: Run stubtest
run: python tests/stubtest_stdlib.py --ignore-unused-allowlist
run: python tests/stubtest_stdlib.py

stubtest-third-party:
name: Check third party stubs with stubtest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Install dependencies
run: pip install $(grep tomli== requirements-tests-py3.txt) $(grep mypy== requirements-tests-py3.txt)
- name: Run stubtest
run: python tests/stubtest_stdlib.py --ignore-unused-allowlist
run: python tests/stubtest_stdlib.py

stubtest-third-party:
name: Check third party stubs with stubtest
Expand Down
3 changes: 0 additions & 3 deletions tests/stubtest_allowlists/py310.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@ tkinter.EventType.__new__
_markupbase.ParserBase.error
asyncio.proactor_events._ProactorReadPipeTransport.__init__
distutils.command.bdist_wininst
logging.Formatter.__init__
logging.LoggerAdapter.__init__
logging.PercentStyle.__init__
py_compile.main
pyclbr.Class.__init__
pyclbr.Function.__init__
Expand Down
3 changes: 2 additions & 1 deletion tests/stubtest_stdlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ def run_stubtest(typeshed_dir: Path) -> int:
"\nCommand run was: {}\n".format(" ".join(cmd)),
file=sys.stderr,
)
print("stubtest failed", file=sys.stderr)
print("\n\n", file=sys.stderr)
print(f'To fix "unused allowlist" errors, remove the corresponding entries from {allowlist_dir}', file=sys.stderr)
return e.returncode
else:
print("stubtest succeeded", file=sys.stderr)
Expand Down
50 changes: 0 additions & 50 deletions tests/stubtest_unused.py
View file
Open in desktop

This file was deleted.