Repository navigation
Allow non-types dependencies - #5769
Merged
Merged
Conversation
Remove the check in check_consistency that ensures that only other type packages from typeshed are being depended on. Instead, add an explanation to CONTRIBUTING that spells out the requirements. This adds a higher, but reasonable burden on maintainers to check the dependencies manually. Part of python#5768
JelleZijlstra
approved these changes
Jul 13, 2021
Collaborator
|
We could check that we depend on the types version of a distribution if one exists ( |
Collaborator
|
We could also check that if the package name starts with |
Collaborator
Author
|
@hauntsaninja That could actually be counter-productive when transitioning from typeshed stubs to built-in stubs. For example, stubs depending on cryptography should not depend on the (obsolete, Python 2) types package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the check in check_consistency that ensures that only other
type packages from typeshed are being depended on. Instead, add an
explanation to CONTRIBUTING that spells out the requirements. This
adds a higher, but reasonable burden on maintainers to check the
dependencies manually.
Part of #5768