Skip to content

functools: use protocol for cmp_to_key return type - #4492

Merged
hauntsaninja merged 2 commits into
python:masterfrom
hauntsaninja:ctk
Aug 30, 2020
Merged

hauntsaninja merged 2 commits into
python:masterfrom
hauntsaninja:ctk

Conversation

@hauntsaninja

Copy link
Copy Markdown
Collaborator

No description provided.

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this help with python/mypy#9372? Intuitively I'd expect it to maybe make it worse.

@hauntsaninja

hauntsaninja commented Aug 29, 2020 •

Copy link
Copy Markdown
Collaborator Author

It doesn't help, but it also doesn't make it worse (afaict)

@hauntsaninja
hauntsaninja merged commit 48c922e into python:master Aug 30, 2020
@hauntsaninja
hauntsaninja deleted the ctk branch August 30, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants