Skip to content

Find unused stubtest whitelist entries - #4157

Merged
srittau merged 2 commits into
python:masterfrom
srittau:3728-stubtest-whitelist
Jun 3, 2020
Merged

srittau merged 2 commits into
python:masterfrom
srittau:3728-stubtest-whitelist

Conversation

@srittau

@srittau srittau commented Jun 2, 2020

Copy link
Copy Markdown
Collaborator

This is currently a GitHub workflow that runs daily and lists all unused
whitelist entries found by running stubtest against current Python
versions on Linux and Windows. The workflow run will succeed if there
are no such entries, and fail otherwise.

In a second step, this should collate the output of the various runs and
create a PR to remove the entries. In that case, the workflow should
probably only run weekly or even monthly to keep the noise down.

Cf. #3728

This is currently a GitHub workflow that runs daily and lists all unused
whitelist entries found by running stubtest against current Python
versions on Linux and Windows. The workflow run will succeed if there
are no such entries, and fail otherwise.

In a second step, this should collate the output of the various runs and
create a PR to remove the entries. In that case, the workflow should
probably only run weekly or even monthly to keep the noise down.

Cf. python#3728
@srittau srittau added the project: infrastructure typeshed build, test, or distribution related label Jun 2, 2020

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall looks good to me. I'm not familiar with Github Actions yaml, so trusting that's all fine.

Comment thread tests/stubtest_unused.py Outdated
@srittau
srittau merged commit d76ad47 into python:master Jun 3, 2020
@srittau
srittau deleted the 3728-stubtest-whitelist branch June 3, 2020 12:37
vishalkuo pushed a commit to vishalkuo/typeshed that referenced this pull request Jun 26, 2020
* Find unused stubtest whitelist entries

This is currently a GitHub workflow that runs daily and lists all unused
whitelist entries found by running stubtest against current Python
versions on Linux and Windows. The workflow run will succeed if there
are no such entries, and fail otherwise.

In a second step, this should collate the output of the various runs and
create a PR to remove the entries. In that case, the workflow should
probably only run weekly or even monthly to keep the noise down.

Cf. python#3728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: infrastructure typeshed build, test, or distribution related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants