Skip to content

stdlib.3.unitest.mock.NonCallableMock signatures - #3846

Merged
srittau merged 21 commits into
python:masterfrom
rodrigondec:master
Mar 20, 2020
Merged

stdlib.3.unitest.mock.NonCallableMock signatures#3846
srittau merged 21 commits into
python:masterfrom
rodrigondec:master

Conversation

@rodrigondec

@rodrigondec rodrigondec commented Mar 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #3842

@rodrigondec rodrigondec changed the title unitest.3.NonCallableMock signatures stdlib.3.unitest.mock.NonCallableMock signatures Mar 12, 2020
@rodrigondec

rodrigondec commented Mar 13, 2020

Copy link
Copy Markdown
Contributor Author

@srittau @JelleZijlstra I think this PR is ready for review 😁

srittau
srittau requested changes Mar 20, 2020
View reviewed changes

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I look forward to have completion in PyCharm. Just one obsolete comment (see below). (I spotted a few problems with _Call, but you just moved it around, so it's out of scope for this PR.)

Comment thread stdlib/3/unittest/mock.pyi Outdated
@rodrigondec
rodrigondec requested a review from srittau March 20, 2020 13:10
@srittau
srittau merged commit ef1d785 into python:master Mar 20, 2020
@rodrigondec rodrigondec mentioned this pull request Mar 20, 2020
Merged
@hauntsaninja hauntsaninja mentioned this pull request Jun 11, 2020
Closed
@jermenkoo jermenkoo mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stdlib.3.unitest.mock missing NonCallableMock methods

2 participants

@rodrigondec @srittau