Repository navigation
Fix abstract classes in 2.7 - #2247
Merged
Merged
Conversation
JelleZijlstra
commented
Jun 17, 2018
| # based on http: //docs.python.org/3.3/library/tempfile.html | ||
| # Adapted for Python 2.7 by Michal Pokorny | ||
|
|
||
| # TODO: Don't use basestring. Use Union[str, bytes] or AnyStr for arguments. |
Member
Author
There was a problem hiding this comment.
None of these TODOs still applies: the file contains no mention of basestring and no Union return types.
JelleZijlstra
commented
Jun 17, 2018
| def normcase(self, path: AnyStr) -> AnyStr: ... | ||
|
|
||
| class _TemporaryFileWrapper(IO[str]): | ||
| close_called = ... # type: bool |
Member
Author
There was a problem hiding this comment.
This attribute doesn't actually exist on _TemporaryFileWrapper.
ilevkivskyi
reviewed
Jun 17, 2018
| from typing import Tuple, IO, Union, AnyStr, Any, overload, Iterator, List, Type, Optional | ||
|
|
||
| import thread | ||
| import random |
Member
There was a problem hiding this comment.
These two imports are actually used below. I would actually write them as from random import Random and from thread import LockType.
ilevkivskyi
approved these changes
Jun 17, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1476.