Skip to content

Make http.client.HTTPResponse a BinaryIO #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Jun 12, 2018
Merged

Make http.client.HTTPResponse a BinaryIO #2218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d16cac
make http.client.HTTPResponse be a BinaryIO
JelleZijlstra Jun 12, 2018
2bbd474
fix __exit__ type for pre-3.5 branch
JelleZijlstra Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions stdlib/3/http/client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ from typing import (
Any, Dict, IO, Iterable, List, Iterator, Mapping, Optional, Tuple, Type, TypeVar,
Union,
overload,
BinaryIO,
)
import email.message
import io
Expand Down Expand Up @@ -79,7 +80,8 @@ responses = ... # type: Dict[int, str]
class HTTPMessage(email.message.Message): ...

if sys.version_info >= (3, 5):
class HTTPResponse(io.BufferedIOBase):
# Ignore errors to work around python/mypy#5027
class HTTPResponse(io.BufferedIOBase, BinaryIO): # type: ignore
msg = ... # type: HTTPMessage
headers = ... # type: HTTPMessage
version = ... # type: int
Expand All @@ -103,7 +105,7 @@ if sys.version_info >= (3, 5):
exc_val: Optional[BaseException],
exc_tb: Optional[types.TracebackType]) -> bool: ...
else:
class HTTPResponse:
class HTTPResponse(BinaryIO):
msg = ... # type: HTTPMessage
headers = ... # type: HTTPMessage
version = ... # type: int
Expand All @@ -122,8 +124,8 @@ else:
def fileno(self) -> int: ...
def __iter__(self) -> Iterator[bytes]: ...
def __enter__(self) -> 'HTTPResponse': ...
def __exit__(self, exc_type: Optional[type],
exc_val: Optional[Exception],
def __exit__(self, exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
exc_tb: Optional[types.TracebackType]) -> bool: ...

class HTTPConnection:
Expand Down