Repository navigation
Move google.protobuf from 2 to 2and3 - #2174
Merged
Merged
Conversation
This should generally be ok. I ran the internal consistency tests and they seemed to pass.
Member
|
See also #2140. |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
* Move google protobuf from 2 to 2and3 This should generally be ok. I ran the internal consistency tests and they seemed to pass. * Convert str to bytes * repr to use str in google.protobuf.internal.containers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working on nipunn1313/mypy-protobuf#22, we found that the typeshed stubs are (as far as we can tell) accurate for python3. Google's protoc does not generate differently for py2 vs py3, so the stubs should be ok.
I moved the stubs to the 2and3 directory and replaced instances of
strwithbytesfor compatibility.