Skip to content

Add support for well_known_types to google/protobuf - #2157

Merged
JelleZijlstra merged 1 commit into
masterfrom
protobuf-fix
May 23, 2018
Merged

JelleZijlstra merged 1 commit into
masterfrom
protobuf-fix

Conversation

@gvanrossum

Copy link
Copy Markdown
Member

Fixes #2154

class Error(Exception): ...
class ParseError(Error): ...

# This is named 'Any' in the original, but that conflicts with typing.Any,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we from typing import Any as Any_ instead to avoid this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that would require more changes to the code below (generated by stubgen), all of which uses Any as meaning typing.Any.

@JelleZijlstra
JelleZijlstra merged commit a392989 into master May 23, 2018
@JelleZijlstra
JelleZijlstra deleted the protobuf-fix branch May 23, 2018 04:57
gwk pushed a commit to gwk/typeshed that referenced this pull request May 29, 2018
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants