Skip to content

make BZ2File and LZMAFile instantiable #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Jun 11, 2018
Merged

make BZ2File and LZMAFile instantiable #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e44a276
make BZ2File instantiable
JelleZijlstra May 13, 2018
76c8b08
make lzma.LZMAFile instantiable
JelleZijlstra May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stdlib/2and3/bz2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import io
import sys
from typing import Any, BinaryIO, IO, Optional, Union
from typing import Any, IO, Optional, Union

if sys.version_info >= (3, 6):
from os import PathLike
Expand All @@ -20,7 +21,7 @@ if sys.version_info >= (3, 3):
errors: Optional[str] = ...,
newline: Optional[str] = ...) -> IO[Any]: ...

class BZ2File(BinaryIO):
class BZ2File(io.BufferedIOBase, IO[bytes]): # type: ignore # python/mypy#5027

@JelleZijlstra JelleZijlstra May 13, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At runtime it inherits from _compression.BaseStream, which is a subclass of BufferedIOBase that adds some private methods.

def __init__(self,
filename: _PathOrFile,
mode: str = ...,
Expand Down
4 changes: 2 additions & 2 deletions stdlib/3.3/lzma.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class LZMACompressor(object):
class LZMAError(Exception): ...


class LZMAFile(BinaryIO):
class LZMAFile(io.BufferedIOBase, IO[bytes]): # type: ignore # python/mypy#5027
def __init__(self,
filename: Optional[_PathOrFile] = ...,
mode: str = ...,
Expand All @@ -84,7 +84,7 @@ class LZMAFile(BinaryIO):
def readable(self) -> bool: ...
def writable(self) -> bool: ...
def peek(self, size: int = ...) -> bytes: ...
def read(self, size: int = ...) -> bytes: ...
def read(self, size: Optional[int] = ...) -> bytes: ...
def read1(self, size: int = ...) -> bytes: ...
def readline(self, size: int = ...) -> bytes: ...
def write(self, data: bytes) -> int: ...
Expand Down