Repository navigation
Precision surgery to take out sqlalchemy test failures - #140
Merged
Merged
Conversation
Member
Author
|
Sorry to keep bothering you, @timabbott, but maybe you can say whether there's a better way to do what I am trying to do in this PR? I also suspect we've run into some kind of import cycle, so possibly if and when mypy improves its handling of those we could also reconsider this. |
Contributor
|
Yeah, that approach looks reasonable given the situation. In general I think it's probably best to avoid adding half-complete broken stubs like the original sqlalchemy ones in the first place, since it's kinda counterproductive (creates lots of errors for anyone using the relevant parts of the module, that wouldn't have been present if we'd just not had stubs). Fortunately I think the CI will prevent from that happening again in the future. |
jukebox
pushed a commit
to jukebox/typeshed
that referenced
this pull request
Apr 11, 2016
* Comment out parts of the sqlalchemy stubs to make tests pass. * Run all tests, one step per Python version.
momandine
pushed a commit
to momandine/typeshed
that referenced
this pull request
Jul 5, 2016
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stubs probably no longer make sense, but there should be enough left for someone to fix them.
All I did was out
##in front of various lines or base classes until the tests pass.Fixes #137.