Repository navigation
make itertools.product more precise - #1393
Merged
Merged
Conversation
JukkaL
reviewed
Jun 14, 2017
|
|
||
| # TODO: Return type should be Iterator[Tuple[..]], but unknown tuple shape. | ||
| # Iterator[Sequence[_T]] loses this type information. | ||
| def product(*p: Iterable[_T], repeat: int = ...) -> Iterator[Sequence[_T]]: ... |
Contributor
There was a problem hiding this comment.
The repeat argument was lost?
Contributor
Author
There was a problem hiding this comment.
My bad. For some reason, I was under the impression that "repeat" doesn't actually exist, on Python 2. I'll send out a PR.
gvanrossum
pushed a commit
that referenced
this pull request
Jun 14, 2017
Fixes a regression introduced by #1393.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes typechecking of code like e.g.
which currently reports a type error.