Repository navigation
Conversation
Avasam
marked this pull request as draft
August 18, 2024 06:50
Avasam
changed the title
…m/Avasam/typeshed into pytype-on-windows-and-Python-3.12
Collaborator
Author
|
Install fails for Python 3.13 because |
Avasam
commented
Sep 12, 2024
Comment on lines
+169
to
+173
| assert len(spec) == 1, f"type checker/linter '{package}' has complex specifier in {REQS_FILE}" | ||
| if package != "pytype": # Temporarily allow complex specification for pytype | ||
| assert len(spec) == 1, f"type checker/linter '{package}' has complex specifier in {REQS_FILE}" | ||
| url = requirements[package].url | ||
| msg = f"type checker/linter '{package}' is not pinned to an exact version in {REQS_FILE}" | ||
| assert str(spec).startswith("=="), msg | ||
| assert str(spec).startswith("==") or "@" in str(url), msg |
Collaborator
Author
There was a problem hiding this comment.
This adds support to target a specific git commit for install. But won't be necessary once an actual pytype version releases.
Contributor
|
We released pytype 2024.09.13 today, which includes basic Python 3.12 support. Windows also likely works but we can't enable our tests for it, yet, because they run too slowly. We'll have to do some more work there before we can officially declare that pytype supports Windows. Not sure if you want to run tests on Windows before that. I opened #12653, which only bumps the pytype version and leaves the remaining caveats unchanged. I don't mind which one gets merged, though. |
…-on-windows-and-Python-3.12
…m/Avasam/typeshed into pytype-on-windows-and-Python-3.12
Avasam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm expecting to have issues, but since it's been updated for Python 3.12 and Windows in the last week I figured may as well try it out.
Edit: Actually looks pretty good! This could work as-is.