Skip to content

Add option to keep tmp dir to stubtest script - #12151

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
srittau:keep-tmp-dir
Oct 3, 2024
Merged

JelleZijlstra merged 4 commits into
python:mainfrom
srittau:keep-tmp-dir

Conversation

@srittau

@srittau srittau commented Jun 17, 2024

Copy link
Copy Markdown
Collaborator

Also add prefix to tmpdir name

@srittau

srittau commented Jun 17, 2024 •

Copy link
Copy Markdown
Collaborator Author

I'm very confused about the mypy error on win32. Can anyone shed a light on what I did wrong?

https://github.com/python/typeshed/actions/runs/9547845403/job/26313973228?pr=12151

@Avasam

Avasam commented Jun 26, 2024 •

Copy link
Copy Markdown
Collaborator

I'm very confused about the mypy error on win32. Can anyone shed a light on what I did wrong?

python/typeshed/actions/runs/9547845403/job/26313973228?pr=12151

idk, the error doesn't even look related to your changes, and the pre-existing check looks correct. Maybe you found a new false-positive by wrapping in an additional try-except block?

@srittau

srittau commented Jul 12, 2024

Copy link
Copy Markdown
Collaborator Author

This is python/mypy#14309. I will disable "possibly-undefined" for now.

@JelleZijlstra
JelleZijlstra merged commit 26b3c69 into python:main Oct 3, 2024
@srittau
srittau deleted the keep-tmp-dir branch October 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants