Repository navigation
add _sqlite3 module - #11174
Merged
Merged
add _sqlite3 module#11174
Conversation
This aligns with the implementation while giving greater fidelity to runtime naming and inheritance Related to python#3968 and python#11141
tungol
marked this pull request as draft
December 16, 2023 21:48
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tungol
marked this pull request as ready for review
December 16, 2023 22:20
tungol
marked this pull request as draft
December 16, 2023 23:27
| _random: 2.7- | ||
| _sitebuiltins: 3.4- | ||
| _socket: 3.0- # present in 2.7 at runtime, but not in typeshed | ||
| _sqlite3: 2.7- |
Member
There was a problem hiding this comment.
Suggested change
| _sqlite3: 2.7- | |
| _sqlite3: 3.0- |
We just merged a PR removing all the 2.7 lines.
Also, general note: I was away for a few weeks and I see you have a number of open PRs that haven't been merged yet. I'm just glancing through my notifications at the moment, but when I find some time I'll try to go over open nondraft typeshed PRs to review what I can.
Contributor
Author
There was a problem hiding this comment.
Appreciated, but no rush
Member
|
This PR also has a lot of merge conflicts. I can review it if the conflicts are resolved and it's taken out of draft. |
This comment has been minimized.
This comment has been minimized.
tungol
marked this pull request as ready for review
October 4, 2024 09:20
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Contributor
Author
|
Thanks, @JelleZijlstra ! This one should be tidied up and good to go now |
JelleZijlstra
self-requested a review
October 4, 2024 14:16
JelleZijlstra
approved these changes
Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with the implementation while giving greater fidelity to runtime naming and inheritance
Related to #3968 and #11141